r69124 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69123‎ | r69124 | r69125 >
Date:00:28, 7 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Added docs
Modified paths:
  • /trunk/extensions/Maps/Services/GoogleMaps/GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/Services/GoogleMaps3/GoogleMaps3.php (modified) (history)
  • /trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3.php (modified) (history)
  • /trunk/extensions/Maps/Services/Maps_MappingService.php (modified) (history)
  • /trunk/extensions/Maps/Services/OSM/OSM.php (modified) (history)
  • /trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php (modified) (history)
  • /trunk/extensions/Maps/Services/OpenLayers/OpenLayers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/GoogleMaps3/GoogleMaps3.php
@@ -22,6 +22,14 @@
2323
2424 $wgHooks['MappingServiceLoad'][] = 'efMapsInitGoogleMaps3';
2525
 26+/**
 27+ * Initialization function for the Google Maps v3 service.
 28+ *
 29+ * @since 0.6.3
 30+ * @ingroup MapsGoogleMaps3
 31+ *
 32+ * @return true
 33+ */
2634 function efMapsInitGoogleMaps3() {
2735 global $egMapsServices, $wgAutoloadClasses;
2836
Index: trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3.php
@@ -37,6 +37,11 @@
3838 );
3939 }
4040
 41+ /**
 42+ * @see MapsMappingService::initParameterInfo
 43+ *
 44+ * @since 0.5
 45+ */
4146 protected function initParameterInfo( array &$parameters ) {
4247 global $egMapsServices, $egMapsGMaps3Type, $egMapsGMaps3Types;
4348
Index: trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayers.php
@@ -40,6 +40,11 @@
4141 $egMapsOLLoadedLayers = array();
4242 }
4343
 44+ /**
 45+ * @see MapsMappingService::initParameterInfo
 46+ *
 47+ * @since 0.5
 48+ */
4449 protected function initParameterInfo( array &$parameters ) {
4550 global $egMapsServices, $egMapsOLLayers, $egMapsOLControls, $egMapsOpenLayersZoom;
4651
@@ -165,6 +170,8 @@
166171 * Removed the layer groups from the layer list, and adds their members back in.
167172 *
168173 * @param array $layers
 174+ * @param string $name
 175+ * @param array $parameters
169176 */
170177 public static function unpackLayerGroups( array &$layers, $name, array $parameters ) {
171178 global $egMapsOLLayerGroups;
Index: trunk/extensions/Maps/Services/OpenLayers/OpenLayers.php
@@ -22,6 +22,14 @@
2323
2424 $wgHooks['MappingServiceLoad'][] = 'efMapsInitOpenLayers';
2525
 26+/**
 27+ * Initialization function for the OpenLayers service.
 28+ *
 29+ * @since 0.6.3
 30+ * @ingroup MapsOpenLayers
 31+ *
 32+ * @return true
 33+ */
2634 function efMapsInitOpenLayers() {
2735 global $egMapsServices, $wgAutoloadClasses;
2836
Index: trunk/extensions/Maps/Services/Maps_MappingService.php
@@ -96,6 +96,8 @@
9797 * Initializes the service parameters.
9898 *
9999 * You can override this method to set service specific parameters in the inheriting class.
 100+ *
 101+ * @param array $parameters
100102 */
101103 protected function initParameterInfo( array &$parameters ) {
102104 }
Index: trunk/extensions/Maps/Services/GoogleMaps/GoogleMaps.php
@@ -22,6 +22,14 @@
2323
2424 $wgHooks['MappingServiceLoad'][] = 'efMapsInitGoogleMaps';
2525
 26+/**
 27+ * Initialization function for the Google Maps v2 service.
 28+ *
 29+ * @since 0.6.3
 30+ * @ingroup MapsGoogleMaps
 31+ *
 32+ * @return true
 33+ */
2634 function efMapsInitGoogleMaps() {
2735 global $egMapsServices, $wgAutoloadClasses;
2836
Index: trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMaps.php
@@ -37,6 +37,11 @@
3838 );
3939 }
4040
 41+ /**
 42+ * @see MapsMappingService::initParameterInfo
 43+ *
 44+ * @since 0.5
 45+ */
4146 protected function initParameterInfo( array &$parameters ) {
4247 global $egMapsServices, $egMapsGoogleMapsType, $egMapsGoogleMapsTypes, $egMapsGoogleAutozoom, $egMapsGMapControls;
4348
Index: trunk/extensions/Maps/Services/OSM/OSM.php
@@ -26,6 +26,7 @@
2727 * Initialization function for the OSM service.
2828 *
2929 * @since 0.6.4
 30+ * @ingroup OSM
3031 *
3132 * @return true
3233 */

Status & tagging log