r68831 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68830‎ | r68831 | r68832 >
Date:13:43, 1 July 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Followup r63389: remove useless CACHE_DB and confusing CACHE_ANYTHING from cache setup
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -406,8 +406,6 @@
407407 No functionality is removed, but speed may be impacted.',
408408 'config-cache-accel' => 'PHP object caching (APC, eAccelerator, XCache or WinCache)',
409409 'config-cache-memcached' => 'Use Memcached (requires additional setup and configuration)',
410 - 'config-cache-db' => 'Cache data into the database',
411 - 'config-cache-anything' => 'MediaWiki will attempt to cache data anywhere possible, except in Memcached, unless indicated explicitely',
412410 'config-memcached-servers' => 'Memcached servers:',
413411 'config-memcached-help' => 'List of IP addresses to use for Memcached.
414412 Should be separated with commas and specify the port to be used (for example: 1.2.3.4:56, 7.8.9.10:11).',
Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -1406,8 +1406,7 @@
14071407 $this->parent->getFieldsetEnd()
14081408 );
14091409
1410 - $caches = array( 'none', 'anything', 'db' );
1411 - $selected = 'db';
 1410+ $caches = array( 'none' );
14121411 if( count( $this->getVar( '_Caches' ) ) ) {
14131412 $caches[] = 'accel';
14141413 $selected = 'accel';

Follow-up revisions

RevisionCommit summaryAuthorDate
r69170r68831 make sure $selected is set.mah08:08, 8 July 2010
r69180Followup r68831, r69170. Set none as the default cache always, never APCdemon10:34, 8 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63389Add object cache settings to advanced setup. Still needs Memcached servers te...demon14:10, 8 March 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   08:04, 8 July 2010

Notice: Undefined variable: selected in /home/mah/domains/winkyfrown.com/public_html/wiki/includes/installer/WebInstaller.php on line 1437

#Comment by 😂 (talk | contribs)   12:34, 22 July 2010

Should be fixed as of r69180

Status & tagging log