r69180 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69179‎ | r69180 | r69181 >
Date:10:34, 8 July 2010
Author:demon
Status:ok
Tags:
Comment:
Followup r68831, r69170. Set none as the default cache always, never APC
Modified paths:
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -1419,10 +1419,8 @@
14201420 );
14211421
14221422 $caches = array( 'none' );
1423 - $selected = $caches[0];
14241423 if( count( $this->getVar( '_Caches' ) ) ) {
14251424 $caches[] = 'accel';
1426 - $selected = 'accel';
14271425 }
14281426 $caches[] = 'memcached';
14291427
@@ -1435,7 +1433,7 @@
14361434 'label' => 'config-cache-options',
14371435 'itemLabelPrefix' => 'config-cache-',
14381436 'values' => $caches,
1439 - 'value' => $selected,
 1437+ 'value' => 'none',
14401438 ) ) .
14411439 $this->parent->getHelpBox( 'config-cache-help' ) .
14421440 '<div id="config-memcachewrapper">' .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68831Followup r63389: remove useless CACHE_DB and confusing CACHE_ANYTHING from ca...demon13:43, 1 July 2010
r69170r68831 make sure $selected is set.mah08:08, 8 July 2010

Status & tagging log