r68801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r68800‎ | r68801 | r68802 >
Date:23:08, 30 June 2010
Author:simetrical
Status:ok
Tags:
Comment:
When using escapenoentities, decode entities

See r67090 for context. Maybe it would be better to alter
normalizeCharReferences() instead? I'm not sure where else it's called.
Modified paths:
  • /trunk/phase3/includes/Sanitizer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Sanitizer.php
——@@ -1063,7 +1063,7 @@
10641064 # hurt.
10651065 $html = htmlspecialchars( $html, ENT_QUOTES );
10661066 $html = str_replace( '&amp;', '&', $html );
1067 - $html = Sanitizer::normalizeCharReferences( $html );
 1067+ $html = Sanitizer::decodeCharReferences( $html );
10681068 return $html;
10691069 }
10701070

Follow-up revisions

RevisionCommit summaryAuthorDate
r68891Make escapenoentities work again, broken by r68801simetrical16:42, 2 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67090Remove most named character references from output...simetrical17:33, 30 May 2010

Status & tagging log