r68802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r68801‎ | r68802 | r68803 >
Date:23:08, 30 June 2010
Author:simetrical
Status:ok
Tags:
Comment:
0="something" is not what we want here, we want id

Html should probably check for the case of missing keys in attributes.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListfiles.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListfiles.php
——@@ -204,7 +204,7 @@
205205 ) );
206206 $s = Html::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'id' => 'mw-listfiles-form' ) ) .
207207 Xml::fieldset( wfMsg( 'listfiles' ) ) .
208 - Html::openElement( 'table', array( 'mw-listfiles-table' ) ) .
 208+ Html::openElement( 'table', array( 'id' => 'mw-listfiles-table' ) ) .
209209 Xml::buildForm( $inputForm, 'table_pager_limit_submit' ) .
210210 $this->getHiddenFields( array( 'limit', 'ilsearch', 'username' ) ) .
211211 Html::closeElement( 'table' ) .

Status & tagging log