r68787 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r68786‎ | r68787 | r68788 >
Date:20:48, 30 June 2010
Author:werdna
Status:reverted (Comments)
Tags:
Comment:
Include WikiEditor resources if necessary
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/View.php
——@@ -1213,6 +1213,11 @@
12141214 $wgOut->addScriptFile( "$basePath/lqt.js" );
12151215 $wgOut->addScriptFile( "$basePath/js/lqt.toolbar.js" );
12161216 $wgOut->addExtensionStyle( "$basePath/lqt.css?{$wgStyleVersion}" );
 1217+
 1218+ if ( class_exists( 'WikiEditorHooks' ) ) {
 1219+ $temp = null;
 1220+ WikiEditorHooks::addModules( $temp );
 1221+ }
12171222
12181223 self::$stylesAndScriptsDone = true;
12191224 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r69764* Consolidate instances of LqtView::addJSandCSS() and eliminate one (apparent...mah22:45, 22 July 2010
r69766* Consolidate instances of LqtView::addJSandCSS() and eliminate one (apparent...mah22:54, 22 July 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   02:09, 23 July 2010

This is awkward.

It looks like part of the problem was the way addJSandCSS() was called semi-randomly throughout the View classes, when, apparently, it is only needed when showThread() is called.

Status & tagging log