r68788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68787‎ | r68788 | r68789 >
Date:21:01, 30 June 2010
Author:adam
Status:deferred
Tags:
Comment:
LiquidThreads - fix for bug 21531, and adding a wrapper around the heading elements
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -39,7 +39,16 @@
4040 float: left;
4141 width: 100%;
4242 }
43 -
 43+.lqt_thread_heading {
 44+ border-bottom: 1px solid #AAAAAA;
 45+ margin-bottom: 0.6em;
 46+ padding: 10px 0 0;
 47+}
 48+.lqt_header {
 49+ border: none;
 50+ margin-bottom: 0;
 51+ display: inline;
 52+}
4453 .lqt_header_commands {
4554 float: right;
4655 clear: both;
@@ -116,19 +125,17 @@
117126 }
118127
119128 .lqt_threadlevel_commands {
120 - /* shift up to be in line with the h2. */
121 - position: relative;
122 - top: -2.9em;
123 - margin-bottom: -2.9em;
124129 float: right;
125 -
126 - color: #777;
 130+ color: #777;
 131+ margin-bottom: 0 !important;
 132+ margin-top: 0;
127133 }
128134
129135 .lqt_threadlevel_commands li {
130136 display: inline;
131137 list-style-type: none;
132138 padding-right: 0.6em;
 139+ line-height: 1em;
133140 }
134141 #lqt_subject_field {
135142 margin-top: 0.7em;
@@ -478,3 +485,24 @@
479486 top: 15px;
480487 height: 32px;
481488 }
 489+
 490+/* Float Clearing - If you confused, http://www.positioniseverything.net/easyclearing.html */
 491+.lqt_thread_heading:after
 492+{
 493+ content: ".";
 494+ display: block;
 495+ height: 0;
 496+ clear: both;
 497+ visibility: hidden;
 498+}
 499+
 500+.lqt_thread_heading
 501+{display: inline-block;}
 502+
 503+/* Hides from IE-mac */
 504+* html .lqt_thread_heading
 505+{height: 1%;}
 506+
 507+.lqt_thread_heading
 508+{display: block;}
 509+/* End hide from IE-mac */
Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -1562,7 +1562,11 @@
15631563 array( 'class' => 'lqt_header', 'id' => $id ),
15641564 $html ) . $commands_html;
15651565 }
1566 -
 1566+
 1567+ // wrap it all in a container
 1568+ $html = Xml::tags( 'div',
 1569+ array( 'class' => 'lqt_thread_heading' ),
 1570+ $html );
15671571 return $html;
15681572 }
15691573

Status & tagging log