r68659 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68658‎ | r68659 | r68660 >
Date:13:18, 28 June 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Renamed Installer to DeployInstaller to avoid conflict and added more docs
Modified paths:
  • /trunk/extensions/Deployment/includes/DeployInstaller.php (added) (history)
  • /trunk/extensions/Deployment/includes/Installer.php (deleted) (history)
  • /trunk/extensions/Deployment/includes/installers/CoreInstaller.php (modified) (history)
  • /trunk/extensions/Deployment/includes/installers/ExtensionInstaller.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/includes/Installer.php
@@ -1,47 +0,0 @@
2 -<?php
3 -
4 -/**
5 - * File holding the Installer class.
6 - * Based on the WordPress 3.0 class WP_Upgrader.
7 - *
8 - * @file Installer.php
9 - * @ingroup Deployment
10 - * @ingroup Installer
11 - *
12 - * @author Jeroen De Dauw
13 - */
14 -
15 -/**
16 - * This documenation group collects source code files with Installer related features.
17 - *
18 - * @defgroup Installer Installer
19 - */
20 -
21 -/**
22 - * Class for Installing or upgrading a local set of files via the Filesystem Abstraction classes from a Zip file.
23 - *
24 - * @author Jeroen De Dauw
25 - */
26 -abstract class Installer {
27 -
28 - public function __construct() {
29 -
30 - }
31 -
32 - public function doInstallation() {
33 -
34 - }
35 -
36 - protected function downloadPackage() {
37 -
38 - }
39 -
40 - protected function unpackPackage() {
41 -
42 - }
43 -
44 - protected function installPackage() {
45 -
46 - }
47 -
48 -}
\ No newline at end of file
Index: trunk/extensions/Deployment/includes/DeployInstaller.php
@@ -0,0 +1,62 @@
 2+<?php
 3+
 4+/**
 5+ * File holding the DeployInstaller class.
 6+ * Based on the WordPress 3.0 class WP_Upgrader.
 7+ *
 8+ * @file Installer.php
 9+ * @ingroup Deployment
 10+ * @ingroup Installer
 11+ *
 12+ * @author Jeroen De Dauw
 13+ */
 14+
 15+/**
 16+ * This documenation group collects source code files with Installer related features.
 17+ *
 18+ * @defgroup Installer Installer
 19+ */
 20+
 21+/**
 22+ * Class for Installing or upgrading a local set of files via the Filesystem Abstraction classes from a Zip file.
 23+ *
 24+ * @author Jeroen De Dauw
 25+ */
 26+abstract class DeployInstaller {
 27+
 28+ /**
 29+ * Constructor
 30+ */
 31+ public function __construct() {
 32+ // TODO
 33+ }
 34+
 35+ /**
 36+ * Initiates the installation procedure.
 37+ */
 38+ public function doInstallation() {
 39+
 40+ }
 41+
 42+ /**
 43+ * Downloads a package needed for the installation.
 44+ */
 45+ protected function downloadPackage() {
 46+
 47+ }
 48+
 49+ /**
 50+ * Unpacks a package needed for the installation.
 51+ */
 52+ protected function unpackPackage() {
 53+
 54+ }
 55+
 56+ /**
 57+ * Installs a package.
 58+ */
 59+ protected function installPackage() {
 60+
 61+ }
 62+
 63+}
\ No newline at end of file
Property changes on: trunk/extensions/Deployment/includes/DeployInstaller.php
___________________________________________________________________
Name: svn:eol-style
164 + native
Index: trunk/extensions/Deployment/includes/installers/ExtensionInstaller.php
@@ -15,6 +15,6 @@
1616 *
1717 * @author Jeroen De Dauw
1818 */
19 -class ExtensionInstaller extends Installer {
 19+class ExtensionInstaller extends DeployInstaller {
2020
2121 }
\ No newline at end of file
Index: trunk/extensions/Deployment/includes/installers/CoreInstaller.php
@@ -15,6 +15,6 @@
1616 *
1717 * @author Jeroen De Dauw
1818 */
19 -class CoreInstaller extends Installer {
 19+class CoreInstaller extends DeployInstaller {
2020
2121 }
\ No newline at end of file

Status & tagging log