r68469 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68468‎ | r68469 | r68470 >
Date:18:23, 23 June 2010
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up r68409 for extensions: shut up PHP Strict Standards notices about "Declaration of Blah::getThumbType() should be compatible with that of MediaHandler::getThumbType()"
Modified paths:
  • /trunk/extensions/FlvHandler/FlvImageHandler.php (modified) (history)
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)
  • /trunk/extensions/PdfHandler/PdfHandler_body.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TimedMediaHandler_body.php (modified) (history)
  • /trunk/extensions/WikiAtHome/NonFreeVideoHandler.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiAtHome/NonFreeVideoHandler.php
@@ -191,7 +191,7 @@
192192 return $this->unpackMetadata( $metadata ) !== false;
193193 }
194194
195 - function getThumbType( $ext, $mime ) {
 195+ function getThumbType( $ext, $mime, $params = null ) {
196196 return array( 'jpg', 'image/jpeg' );
197197 }
198198
Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -176,7 +176,7 @@
177177 return $this->unpackMetadata( $metadata ) !== false;
178178 }
179179
180 - function getThumbType( $ext, $mime ) {
 180+ function getThumbType( $ext, $mime, $params = null ) {
181181 return array( 'jpg', 'image/jpeg' );
182182 }
183183
Index: trunk/extensions/FlvHandler/FlvImageHandler.php
@@ -117,7 +117,7 @@
118118 return wfGetFLVsize( $path );
119119 }*/
120120
121 - function getThumbType( $ext, $mime ) {
 121+ function getThumbType( $ext, $mime, $params = null ) {
122122 return array( 'png', 'image/png' );
123123 }
124124
Index: trunk/extensions/TimedMediaHandler/TimedMediaHandler_body.php
@@ -171,7 +171,7 @@
172172 return $this->unpackMetadata( $metadata ) !== false;
173173 }
174174
175 - function getThumbType( $ext, $mime ) {
 175+ function getThumbType( $ext, $mime, $params = null ) {
176176 return array( 'jpg', 'image/jpeg' );
177177 }
178178
Index: trunk/extensions/PdfHandler/PdfHandler_body.php
@@ -173,7 +173,7 @@
174174 return $this->getPdfImage( $image, $path )->getImageSize();
175175 }
176176
177 - function getThumbType( $ext, $mime ) {
 177+ function getThumbType( $ext, $mime, $params = null ) {
178178 global $wgPdfOutputExtension;
179179 static $mime;
180180

Follow-up revisions

RevisionCommit summaryAuthorDate
r71188MFT r68409, r68468, r68469, r68714: supporting revisions for PagedTiffHandler.tstarling02:19, 17 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68409passing thumbnail params to getThumbType, as suggested by TimStarling in a co...daniel16:01, 22 June 2010

Status & tagging log