r68468 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68467‎ | r68468 | r68469 >
Date:18:18, 23 June 2010
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up r68409: shut up PHP Strict Standards notices about "Declaration of Blah::getThumbType() should be compatible with that of MediaHandler::getThumbType()"
Modified paths:
  • /trunk/phase3/includes/media/BMP.php (modified) (history)
  • /trunk/phase3/includes/media/DjVu.php (modified) (history)
  • /trunk/phase3/includes/media/SVG.php (modified) (history)
  • /trunk/phase3/includes/media/Tiff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/BMP.php
@@ -17,7 +17,7 @@
1818 }
1919
2020 // Render files as PNG
21 - function getThumbType( $text, $mime ) {
 21+ function getThumbType( $text, $mime, $params = null ) {
2222 return array( 'png', 'image/png' );
2323 }
2424
Index: trunk/phase3/includes/media/SVG.php
@@ -106,7 +106,7 @@
107107 return wfGetSVGsize( $path );
108108 }
109109
110 - function getThumbType( $ext, $mime ) {
 110+ function getThumbType( $ext, $mime, $params = null ) {
111111 return array( 'png', 'image/png' );
112112 }
113113
Index: trunk/phase3/includes/media/DjVu.php
@@ -181,7 +181,7 @@
182182 return $this->getDjVuImage( $image, $path )->getImageSize();
183183 }
184184
185 - function getThumbType( $ext, $mime ) {
 185+ function getThumbType( $ext, $mime, $params = null ) {
186186 global $wgDjvuOutputExtension;
187187 static $mime;
188188 if ( !isset( $mime ) ) {
Index: trunk/phase3/includes/media/Tiff.php
@@ -26,7 +26,7 @@
2727 return true;
2828 }
2929
30 - function getThumbType( $ext, $mime ) {
 30+ function getThumbType( $ext, $mime, $params = null ) {
3131 global $wgTiffThumbnailType;
3232 return $wgTiffThumbnailType;
3333 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r71188MFT r68409, r68468, r68469, r68714: supporting revisions for PagedTiffHandler.tstarling02:19, 17 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68409passing thumbnail params to getThumbType, as suggested by TimStarling in a co...daniel16:01, 22 June 2010

Status & tagging log