r67901 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67900‎ | r67901 | r67902 >
Date:14:59, 12 June 2010
Author:hartman
Status:ok (Comments)
Tags:
Comment:
Bug 23747. Move the "Compare revisions" button before the RevDel and RevMove buttons.
All three are submit buttons, and the first will be used as the default action.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
@@ -381,6 +381,13 @@
382382 $s .= Xml::hidden( 'action', 'historysubmit' ) . "\n";
383383
384384 $this->buttons = '<div>';
 385+ $this->buttons .= $this->submitButton( wfMsg( 'compareselectedversions'),
 386+ array(
 387+ 'class' => 'historysubmit',
 388+ 'accesskey' => wfMsg( 'accesskey-compareselectedversions' ),
 389+ 'title' => wfMsg( 'tooltip-compareselectedversions' ),
 390+ )
 391+ ) . "\n";
385392 if( $wgUser->isAllowed('deleterevision') ) {
386393 $float = $wgContLang->alignEnd();
387394 # Note bug #20966, <button> is non-standard in IE<8
@@ -409,13 +416,6 @@
410417 wfMsg( 'revisionmoveselectedversions' )
411418 ) . "\n";
412419 }
413 - $this->buttons .= $this->submitButton( wfMsg( 'compareselectedversions'),
414 - array(
415 - 'class' => 'historysubmit',
416 - 'accesskey' => wfMsg( 'accesskey-compareselectedversions' ),
417 - 'title' => wfMsg( 'tooltip-compareselectedversions' ),
418 - )
419 - ) . "\n";
420420 $this->buttons .= '</div>';
421421 $s .= $this->buttons . '<ul id="pagehistory">' . "\n";
422422 return $s;
Index: trunk/phase3/RELEASE-NOTES
@@ -190,6 +190,8 @@
191191 * (bug 23688) Correct mime types for Office 2007 OpenXML documents.
192192 * (bug 23787) Corrected $wgDefaultSkin's comment in DefaultSettings.php
193193 * (bug 23797) Xml::input() now allows '0' for the value parameter
 194+* (bug 23747) Make sure that on History pages, the RevDel button is not
 195+ accidently activated when hitting enter.
194196
195197 === API changes in 1.17 ===
196198 * (bug 22738) Allow filtering by action type on query=logevent.

Sign-offs

UserFlagDate
Dima iotested17:59, 1 October 2011 (struck 17:59, 1 October 2011)
Dima iotested18:00, 1 October 2011

Comments

#Comment by Happy-melon (talk | contribs)   15:38, 15 December 2010

I wonder why two of these are implemented as <button>s and the third as an <input>...??

#Comment by Dima io (talk | contribs)   18:01, 1 October 2011

Ooops, sorry) I accedently use Sign off button) I hope nothing bad happens)

Status & tagging log