r67902 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67901‎ | r67902 | r67903 >
Date:15:25, 12 June 2010
Author:liangent
Status:deferred
Tags:
Comment:
Use $wgContLang->alignEnd() instead of hard-coded 'right' to provide better support for rtl languages
Modified paths:
  • /trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php
@@ -355,7 +355,7 @@
356356 }
357357
358358 function onCategoryPageView_buildSortkeySelectForm( $current = '' ) {
359 - global $wgCategoryMultisortSortkeySettings, $wgArticle, $wgScript;
 359+ global $wgCategoryMultisortSortkeySettings, $wgArticle, $wgScript, $wgContLang;
360360
361361 $html = '';
362362
@@ -388,7 +388,7 @@
389389 'action' => $wgScript,
390390 'method' => 'get',
391391 'id' => 'categorymultisort-select-form',
392 - 'style' => 'float: right;',
 392+ 'style' => "float: {$wgContLang->alignEnd()};",
393393 ), $html );
394394 }
395395

Status & tagging log