r67871 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67870‎ | r67871 | r67872 >
Date:22:01, 11 June 2010
Author:adam
Status:resolved
Tags:
Comment:
SimpleSearch - switching several css rules from ems to px to ensure consistent rendering across browsers
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
@@ -347,7 +347,7 @@
348348 margin-top: 0.4em;
349349 }
350350 div#simpleSearch {
351 - margin-top: 0.5em;
 351+ margin-top: 0.65em;
352352 position: relative;
353353 border: solid 1px #AAAAAA;
354354 background-color: white;
@@ -356,15 +356,15 @@
357357 background-repeat: repeat-x;
358358 }
359359 div#simpleSearch label {
360 - font-size: 0.8em;
 360+ font-size: 13px;
361361 top: 0.25em;
362362 }
363363 div#simpleSearch input#searchInput {
364364 margin: 0;
365365 border-width: 0;
366 - padding: 0.25em;
 366+ padding: 3px;
367367 line-height: 1em;
368 - font-size: 0.8em;
 368+ font-size: 13px;
369369 width: 14em;
370370 background-color: transparent;
371371 }
@@ -373,7 +373,7 @@
374374 margin: 0;
375375 padding: 0;
376376 width: 1.75em;
377 - height: 1.5em;
 377+ height: 16px;
378378 border: none;
379379 cursor: pointer;
380380 background-color: transparent;
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -347,7 +347,7 @@
348348 margin-top: 0.4em;
349349 }
350350 div#simpleSearch {
351 - margin-top: 0.5em;
 351+ margin-top: 0.65em;
352352 position: relative;
353353 border: solid 1px #AAAAAA;
354354 background-color: white;
@@ -356,15 +356,15 @@
357357 background-repeat: repeat-x;
358358 }
359359 div#simpleSearch label {
360 - font-size: 0.8em;
 360+ font-size: 13px;
361361 top: 0.25em;
362362 }
363363 div#simpleSearch input#searchInput {
364364 margin: 0;
365365 border-width: 0;
366 - padding: 0.25em;
 366+ padding: 3px;
367367 line-height: 1em;
368 - font-size: 0.8em;
 368+ font-size: 13px;
369369 width: 14em;
370370 background-color: transparent;
371371 }
@@ -373,7 +373,7 @@
374374 margin: 0;
375375 padding: 0;
376376 width: 1.75em;
377 - height: 1.5em;
 377+ height: 16px;
378378 border: none;
379379 cursor: pointer;
380380 background-color: transparent;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1537,7 +1537,7 @@
15381538 * to ensure that client-side caches do not keep obsolete copies of global
15391539 * styles.
15401540 */
1541 -$wgStyleVersion = '288';
 1541+$wgStyleVersion = '289';
15421542
15431543 /**
15441544 * This will cache static pages for non-logged-in users to reduce

Follow-up revisions

RevisionCommit summaryAuthorDate
r68011Added some comments to some CSS rules added in r67871 which are suspect on fi...tparscal18:05, 14 June 2010
r680271.16wmf4: Merge Vector and UsabilityInitiative fixes from trunk: r67836, r678...catrope20:25, 14 June 2010

Status & tagging log