r68011 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68010‎ | r68011 | r68012 >
Date:18:05, 14 June 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added some comments to some CSS rules added in r67871 which are suspect on first glance, but reasonable if you do some reasearch. These comments should help others to understand what's going on.
Modified paths:
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
@@ -356,6 +356,10 @@
357357 background-repeat: repeat-x;
358358 }
359359 div#simpleSearch label {
 360+ /*
 361+ * DONT PANIC! Browsers that won't scale this properly are the same browsers that have JS issues that prevent
 362+ * this from ever being shown anyways.
 363+ */
360364 font-size: 13px;
361365 top: 0.25em;
362366 }
@@ -364,6 +368,10 @@
365369 border-width: 0;
366370 padding: 3px;
367371 line-height: 1em;
 372+ /*
 373+ * DONT PANIC! Browsers that won't scale this properly are the same browsers that have JS issues that prevent
 374+ * this from ever being shown anyways.
 375+ */
368376 font-size: 13px;
369377 width: 14em;
370378 background-color: transparent;
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -356,6 +356,10 @@
357357 background-repeat: repeat-x;
358358 }
359359 div#simpleSearch label {
 360+ /*
 361+ * DONT PANIC! Browsers that won't scale this properly are the same browsers that have JS issues that prevent
 362+ * this from ever being shown anyways.
 363+ */
360364 font-size: 13px;
361365 top: 0.25em;
362366 }
@@ -364,6 +368,10 @@
365369 border-width: 0;
366370 padding: 3px;
367371 line-height: 1em;
 372+ /*
 373+ * DONT PANIC! Browsers that won't scale this properly are the same browsers that have JS issues that prevent
 374+ * this from ever being shown anyways.
 375+ */
368376 font-size: 13px;
369377 width: 14em;
370378 background-color: transparent;

Follow-up revisions

RevisionCommit summaryAuthorDate
r68051SimpleSearch - re-disabling the re-enabled textinput changing with suggestion...adam02:25, 15 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67871SimpleSearch - switching several css rules from ems to px to ensure consisten...adam22:01, 11 June 2010

Status & tagging log