r67722 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r67721‎ | r67722 | r67723 >
Date:14:44, 9 June 2010
Author:platonides
Status:reverted
Tags:
Comment:
Remove extra spaces and perform a second pass actually doing the sum.
Since the makefile now uses bash as shell, this takes advantage of some bashisms.
Depends on: bash, sed, grep, bc
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Makefile (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Makefile
——@@ -132,7 +132,8 @@
133133 Vector/Vector.hooks.php: $(VECTOR_HOOKS)
134134
135135 %.hooks.php: $(WIKIEDITOR_HOOKS)
136 - for file in $?; do basefile="$${file#$(shell echo $* | sed "s/\([^\/]*\/\).*/\\1/")}"; sed -i "s/\(.*'src' => '$${basefile//\//\\/}', 'version' => \)\([0-9 +]*\)\(.*\)/\\1 \\2+ 1 \\3/" $@; done
 136+ for file in $?; do basefile="$${file#$(shell echo $* | sed "s/\([^\/]*\/\).*/\\1/")}"; sed -i "s/\(.*'src' => '$${basefile//\//\\/}', 'version' => \)\([0-9+]*\)\(.*\)/\\1\\2+1\\3/" $@; \
 137+ for i in $$(grep --only-matching -P " ([0-9]+(\+[0-9]))+ " $@); do sed -i "s/ $$i / $$(bc <<< $$i) /" $@; done; done
137138
138139 # Actions
139140

Follow-up revisions

RevisionCommit summaryAuthorDate
r67743Reverted r67722, r67720, r67716, r67715 - (auto version bumping). This is a g...tparscal18:49, 9 June 2010

Status & tagging log