r67715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r67714‎ | r67715 | r67716 >
Date:13:13, 9 June 2010
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
Add a basic version incrementer.
Makefiles are here to make the whole work for you.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/Makefile (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Makefile
——@@ -57,15 +57,31 @@
5858 Vector/Modules/FooterCleanup/FooterCleanup.js\
5959 Vector/Modules/SimpleSearch/SimpleSearch.js
6060
61 -all: \
 61+USABILITYINITIATIVE_HOOKS := \
6262 css/combined.css\
6363 css/combined.min.css\
 64+ $(CSS)\
6465 js/plugins.combined.js\
6566 js/plugins.combined.min.js\
 67+ $(PLUGINS)
 68+
 69+WIKIEDITOR_HOOKS := \
 70+ $(WIKIEDITOR_MODULES)\
6671 WikiEditor/WikiEditor.combined.js\
67 - WikiEditor/WikiEditor.combined.min.js\
 72+ WikiEditor/WikiEditor.combined.min.js
 73+
 74+VECTOR_HOOKS := \
 75+ $(VECTOR_MODULES)\
6876 Vector/Vector.combined.js\
6977 Vector/Vector.combined.min.js
 78+
 79+all: \
 80+ $(USABILITYINITIATIVE_HOOKS)\
 81+ $(WIKIEDITOR_HOOKS)\
 82+ UsabilityInitiative.hooks.php\
 83+ WikiEditor/WikiEditor.hooks.php\
 84+ Vector/Vector.hooks.php\
 85+
7086
7187 # JavaScript Combination
7288
——@@ -108,6 +124,15 @@
109125 jsmin:
110126 type -P jsmin &>/dev/null || ( wget http://www.crockford.com/javascript/jsmin.c; gcc jsmin.c -o jsmin )
111127
 128+# Simple incrementer of versions
 129+
 130+UsabilityInitiative.hooks.php: $(USABILITYINITIATIVE_HOOKS)
 131+ for file in $?; do basefile=$${file}; sed -i "s/\(.*'src' => '$${basefile//\//\\/}', 'version' => \)\([0-9 +]*\)\(.*\)/\\1 \\2+ 1 \\3/" $@; done
 132+WikiEditor/WikiEditor.hooks.php: $(WIKIEDITOR_HOOKS)
 133+ for file in $?; do basefile="$${file#WikiEditor/}"; sed -i "s/\(.*'src' => '$${basefile//\//\\/}', 'version' => \)\([0-9 +]*\)\(.*\)/\\1 \\2+ 1 \\3/" $@; done
 134+Vector/Vector.hooks.php: $(VECTOR_HOOKS)
 135+ for file in $?; do basefile=$${file#Vector/}; sed -i "s/\(.*'src' => '$${basefile//\//\\/}', 'version' => \)\([0-9 +]*\)\(.*\)/\\1 \\2+ 1 \\3/" $@; done
 136+
112137 # Actions
113138
114139 distclean: clean

Follow-up revisions

RevisionCommit summaryAuthorDate
r67716Follow up r67715. Make that just one metarule.platonides13:19, 9 June 2010
r67743Reverted r67722, r67720, r67716, r67715 - (auto version bumping). This is a g...tparscal18:49, 9 June 2010

Comments

#Comment by Catrope (talk | contribs)   13:56, 9 June 2010 
catrope@roanLaptop:~/mediawiki/trunk/extensions/UsabilityInitiative$ make
cat js/usability.js js/js2stopgap/ui.core.js js/js2stopgap/ui.datepicker.js js/js2stopgap/ui.dialog.js js/js2stopgap/ui.draggable.js js/js2stopgap/ui.resizable.js js/js2stopgap/ui.tabs.js js/plugins/jquery.async.js js/plugins/jquery.autoEllipsis.js js/plugins/jquery.browser.js js/plugins/jquery.collapsibleTabs.js js/plugins/jquery.color.js js/plugins/jquery.cookie.js js/plugins/jquery.delayedBind.js js/plugins/jquery.expandableField.js js/plugins/jquery.suggestions.js js/plugins/jquery.textSelection.js js/plugins/jquery.wikiEditor.js js/plugins/jquery.wikiEditor.dialogs.js js/plugins/jquery.wikiEditor.highlight.js js/plugins/jquery.wikiEditor.preview.js js/plugins/jquery.wikiEditor.publish.js js/plugins/jquery.wikiEditor.templateEditor.js js/plugins/jquery.wikiEditor.toc.js js/plugins/jquery.wikiEditor.toolbar.js js/thirdparty/contentCollector.js > js/plugins.combined.js
if [ -e ./jsmin ]; then ./jsmin < js/plugins.combined.js > js/plugins.combined.min.js;\
        else jsmin < js/plugins.combined.js > js/plugins.combined.min.js; fi
for file in js/plugins.combined.js js/plugins.combined.min.js js/plugins/jquery.wikiEditor.toolbar.js; do basefile="${file#UsabilityInitiative}"; sed -i "s/\(.*'src' => '${basefile//\//\\/}', 'version' => \)\([0-9 +]*\)\(.*\)/\\1 \\2+ 1 \\3/" UsabilityInitiative.hooks.php; done
/bin/sh: Bad substitution
make: *** [UsabilityInitiative.hooks.php] Error 2
#Comment by Platonides (talk | contribs)   14:16, 9 June 2010

dash problem. Fixed in r67720

Status & tagging log