r67678 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67677‎ | r67678 | r67679 >
Date:00:10, 9 June 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Updated main and feedback sections for English translation, other translations need to follow suit.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php
@@ -68,12 +68,29 @@
6969 'prefswitch-success-feedback' => 'Your feedback has been sent.',
7070 'prefswitch-return' => '<hr style="clear:both">
7171 Return to <span class="plainlinks">[$1 $2]</span>.',
72 - 'prefswitch-main' => "<div class=\"plainlinks\">
73 -[[file:UsabilityNavigation.png|thumb|446px|<big><font color=green>'''''Wikipedia's new theme, \"Vector\"'''''</font></big>]]
74 -We at the Wikimedia Foundation have been working hard to make things easier for our users. We are excited to share some improvements, including a new look and feel and simplified editing features. These changes are intended to make it easier for new contributors to get started, and are based on our [http://usability.wikimedia.org/wiki/Usability,_Experience,_and_Evaluation_Study usability testing conducted over the last year]. Improving the usability of our projects is a priority of the Wikimedia Foundation and we will be sharing more updates in the future. For more details, visit the related Wikimedia [http://blog.wikimedia.org/2010/05/13/a-new-look-for-wikipedia/ blog post].
75 -<div style=\"clear:both\"></div>
76 -[[file:UsabilityToolbar.png|thumb|446px|<big><font color=green>'''''New editing toolbar'''''</font></big>]]
77 -[[file:UsabilityDialogs.png|thumb|446px|<big><font color=green>'''''New dialog box for entering links'''''</font></big>]]
 72+ 'prefswitch-main' => "{| border=\"0\" align=\"right\" style=\"margin-left:1em\"
 73+| align=\"center\" |
 74+{| border=\"0\" style=\"background:#F3F3F3;border: 1px solid #CCCCCC;padding:10px;\"
 75+| [[Image:VectorNavigation-en.png|401px|]]
 76+|-
 77+| A screenshot of Wikipedia's new navigation interface <small>[[Media:VectorNavigation.png|(enlarge)]]</small>
 78+|}
 79+|-
 80+| align=\"center\" |
 81+{| border=\"0\" style=\"background:#F3F3F3;border: 1px solid #CCCCCC;padding:10px;\"
 82+| [[Image:VectorEditorBasic-en.png|401px|]]
 83+|-
 84+| A screenshot of the basic page editing interface <small>[[Media:VectorEditorBasic.png|(enlarge)]]</small>
 85+|}
 86+|-
 87+| align=\"center\" |
 88+{| border=\"0\" style=\"background:#F3F3F3;border: 1px solid #CCCCCC;padding:10px;\"
 89+| [[Image:VectorLinkDialog-en.png|401px|]]
 90+|-
 91+| A screenshot of the new dialog box for entering links
 92+|}
 93+|}
 94+The Wikimedia Foundation's User Experience Team has been working with volunteers from the community to make things easier for you. We are excited to share some improvements, including a new look and feel and simplified editing features. These changes are intended to make it easier for new contributors to get started, and are based on our [http://usability.wikimedia.org/wiki/Usability,_Experience,_and_Evaluation_Study usability testing conducted over the last year]. Improving the usability of our projects is a priority of the Wikimedia Foundation and we will be sharing more updates in the future. For more details, visit the related Wikimedia [http://blog.wikimedia.org/2010/05/13/a-new-look-for-wikipedia blog post].
7895
7996 === Here's what we have changed ===
8097 * '''Navigation:''' We have improved the navigation for reading and editing pages. Now, the tabs at the top of each page more clearly define whether you are viewing the page or discussion page, and whether you are reading or editing a page.
@@ -81,12 +98,11 @@
8299 * '''Link wizard:''' An easy-to-use tool allows you to add links to other wiki pages as well as links to external sites.
83100 * '''Search improvements:''' We have improved search suggestions to get you to the page you are looking for more quickly.
84101 * '''Other new features:''' We have also introduced a table wizard to make creating tables easier and find and a replace feature to simplify page editing.
85 -* '''Wikipedia logo:''' We have updated our logo. Read more at the [http://blog.wikimedia.org/2010/05/13/wikipedia-in-3d/ Wikimedia blog].</div>",
 102+* '''Wikipedia logo:''' We have updated our logo. Read more at the [http://blog.wikimedia.org/2010/05/13/wikipedia-in-3d Wikimedia blog].",
86103 'prefswitch-main-anon' => "===Take me back===
87104 If you would like to turn off the new features, <span class=\"plainlinks\">[$1 click here]</span>. You will be asked to login or create an account first.",
88105 'prefswitch-main-on' => "===Feedback?===
89 -We would love to hear from you. Please visit our <span class=\"plainlinks\">[$1 feedback page]</span> or, if you are interested in our ongoing efforts to improve the software, visit our [http://usability.wikimedia.org usability wiki] for more information.
90 -
 106+We would love to hear from you. Please visit our [$1 feedback page] or, if you are interested in our ongoing efforts to improve the software, visit our [http://usability.wkimedia.org usability wiki] for more information.
91107 ===Take me back!===
92108 If you would like to turn off the new features, please <span class=\"plainlinks\">[$2 click here]</span>.",
93109 'prefswitch-main-off' => "===Try them out!===

Comments

#Comment by Catrope (talk | contribs)   08:42, 9 June 2010

You killed class="plainlinks", was that intentional?

#Comment by Trevor Parscal (WMF) (talk | contribs)   16:57, 9 June 2010

Yeah, we need to add it around ALL of the content on the page, not just the main part. In fact, I've done that now with r67734.

Status & tagging log