r67734 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67733‎ | r67734 | r67735 >
Date:16:56, 9 June 2010
Author:tparscal
Status:ok
Tags:
Comment:
Removed plainlinks classes spans from i18n messages, wrapped entire special page with a single plainlinks classed div. This makes the messages easier to translate and keep consistent.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.i18n.php
@@ -103,11 +103,11 @@
104104 ===Feedback?===
105105 We would love to hear from you. Please visit our [[$1|feedback page]] or, if you are interested in our ongoing efforts to improve the software, visit our [http://usability.wkimedia.org usability wiki] for more information.",
106106 'prefswitch-main-anon' => "===Take me back===
107 -<span class=\"plainlinks\">[$1 Click here to turn off the new features]</span>. You will be asked to login or create an account first.",
 107+[$1 Click here to turn off the new features]. You will be asked to login or create an account first.",
108108 'prefswitch-main-on' => "===Take me back!===
109 -<span class=\"plainlinks\">[$2 Click here to turn off the new features]</span>.",
 109+[$2 Click here to turn off the new features].",
110110 'prefswitch-main-off' => "===Try them out!===
111 -<span class=\"plainlinks\">[$1 Click here to enable the new features]</span>.",
 111+[$1 Click here to enable the new features].",
112112 'prefswitch-survey-intro-feedback' => 'We would love to hear from you.
113113 Please fill out the optional survey below before clicking "[[#prefswitch-survey-submit-feedback|{{int:Prefswitch-survey-submit-feedback}}]]".',
114114 'prefswitch-survey-intro-off' => 'Thanks for trying out our new features.
@@ -2216,7 +2216,7 @@
22172217
22182218 === Terugkoppeling? ===
22192219 Wij horen graag van u.
2220 -Bezoek onze <span class=\"plainlinks\">[[$1|pagina voor terugkoppeling]], of ga naar de [http://usability.wkimedia.org bruikbaarheidswiki] voor meer informatie als u geïnteresseerd bent in onze toekomstige plannen.</span>",
 2220+Bezoek onze [[$1|pagina voor terugkoppeling]], of ga naar de [http://usability.wkimedia.org bruikbaarheidswiki] voor meer informatie als u geïnteresseerd bent in onze toekomstige plannen.",
22212221 'prefswitch-main-anon' => '===Terug===
22222222 <span class="plainlinks">[$1 U kunt de nieuwe functionaliteit uitschakelen]</span>. U wordt dan gevraagd om aan te melden of te registreren.',
22232223 'prefswitch-main-on' => '=== Nee, bedankt! ===
Index: trunk/extensions/UsabilityInitiative/PrefSwitch/SpecialPrefSwitch.php
@@ -110,6 +110,7 @@
111111 UsabilityInitiativeHooks::initialize();
112112 UsabilityInitiativeHooks::addScript( 'PrefSwitch/PrefSwitch.js', $wgPrefSwitchStyleVersion );
113113 UsabilityInitiativeHooks::addStyle( 'PrefSwitch/PrefSwitch.css', $wgPrefSwitchStyleVersion );
 114+ $wgOut->addHtml( '<div class="plainlinks">' );
114115 // Handle various modes
115116 if ( $wgRequest->getCheck( 'mode' ) && $wgUser->isLoggedIn() ) {
116117 switch ( $wgRequest->getVal( 'mode' ) ) {
@@ -192,6 +193,7 @@
193194 break;
194195 }
195196 }
 197+ $wgOut->addHtml( '</div>' );
196198 }
197199
198200 /* Private Functions */

Status & tagging log