r67465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67464‎ | r67465 | r67466 >
Date:14:03, 6 June 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
(bug 23021) Mediawiki should not warn if the sesion path is not writable and should not suggest putting it in open_basedir
Modified paths:
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -207,7 +207,11 @@
208208 function startSession() {
209209 $sessPath = $this->getSessionSavePath();
210210 if( $sessPath != '' ) {
211 - if( !is_dir( $sessPath ) || !is_writeable( $sessPath ) ) {
 211+ if( strval( ini_get( 'open_basedir' ) ) != '' ) {
 212+ // we need to skip the following check when open_basedir is on.
 213+ // The session path probably *wont* be writable by the current
 214+ // user, and telling them to change it is bad. Bug 23021.
 215+ } elseif( !is_dir( $sessPath ) || !is_writeable( $sessPath ) ) {
212216 $this->showError( 'config-session-path-bad', $sessPath );
213217 return false;
214218 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r78259Remove bogus session_path checks. Reverts r67465, r63813, r75256, r64717.demon17:25, 12 December 2010

Comments

#Comment by Platonides (talk | contribs)   16:37, 6 June 2010

The bug in PHP is fixed in 5.2.4 but perhaps it affects previous versions which are supported by us, so it may be advisable to show a warning (upgrade your php!) in that case.

#Comment by Hashar (talk | contribs)   10:38, 11 November 2010

Marking fixme.

Status & tagging log