r64717 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64716‎ | r64717 | r64718 >
Date:19:06, 7 April 2010
Author:freakolowsky
Status:reverted (Comments)
Tags:
Comment:
session path extraction fixed
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
——@@ -236,7 +236,8 @@
237237 */
238238 private function getSessionSavePath() {
239239 $path = ini_get( 'session.save_path' );
240 - $path = substr( $path, strrpos( $path, ';' ) );
 240+ $path = ltrim( substr( $path, strrpos( $path, ';' ) ), ';');
 241+
241242 return $path;
242243 }
243244

Follow-up revisions

RevisionCommit summaryAuthorDate
r75256Fix r63813, r64717 (session path detection in new installer). Surprise surpri...demon16:02, 23 October 2010
r78259Remove bogus session_path checks. Reverts r67465, r63813, r75256, r64717.demon17:25, 12 December 2010

Comments

#Comment by Tim Starling (talk | contribs)   02:06, 30 June 2010

This does not accurately simulate the PHP code: 

	/* we do not use zend_memrchr() since path can contain ; itself */
	if ((p = strchr(new_value, ';'))) {
		char *p2;
		p++;
		if ((p2 = strchr(p, ';'))) {
			p = p2 + 1;
		}
	} else {
		p = new_value;
	}

Status & tagging log