r65029 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65028‎ | r65029 | r65030 >
Date:14:47, 14 April 2010
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
Follow-up to r65027: Prefix all hidden fields with wp. This was not necessary since HTMLForm.php r64866, which needs reverting or fixing.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -958,14 +958,14 @@
959959 );
960960 }
961961
962 - $descriptor['DestFileWarningAck'] = array(
 962+ $descriptor['wpDestFileWarningAck'] = array(
963963 'type' => 'hidden',
964964 'id' => 'wpDestFileWarningAck',
965965 'default' => $this->mDestWarningAck ? '1' : '',
966966 );
967967
968968 if ( $this->mForReUpload ) {
969 - $descriptor['ForReUpload'] = array(
 969+ $descriptor['wpForReUpload'] = array(
970970 'type' => 'hidden',
971971 'id' => 'wpForReUpload',
972972 'default' => '1',

Follow-up revisions

RevisionCommit summaryAuthorDate
r650311.16wmf4: MFT r65029catrope14:56, 14 April 2010
r65040From r64866, more consistent behaviour of hidden field names. May affect r65...happy-melon21:42, 14 April 2010
r66942MFT r65029: fix form field names broken by r66941tstarling06:32, 27 May 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64866Improvements and fixes to HTMLForm:...happy-melon12:03, 10 April 2010
r65027Fix regression in unwatch links sent out by enotif. {{FULLPAGENAMEE}} happens...demon14:00, 14 April 2010

Comments

#Comment by Bryan (talk | contribs)   15:00, 14 April 2010

That meant to say followup to r65025

Status & tagging log