r67101 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67100‎ | r67101 | r67102 >
Date:18:59, 30 May 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r66990. Fix parser tests.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
@@ -402,7 +402,7 @@
403403 !! input
404404 <pre width="8" style="border-width: expression(alert(document.cookie))">Narrow screen goodies</pre>
405405 !! result
406 -<pre width="8">Narrow screen goodies</pre>
 406+<pre width="8" style="/* insecure input */">Narrow screen goodies</pre>
407407
408408 !! end
409409
@@ -4269,7 +4269,7 @@
42704270 !! input
42714271 <div style="{{dangerous style attribute}}"></div>
42724272 !! result
4273 -<div></div>
 4273+<div style="/* insecure input */"></div>
42744274
42754275 !! end
42764276
@@ -4287,7 +4287,7 @@
42884288 !! input
42894289 {{div style|width: expression(alert(document.cookie))}}
42904290 !! result
4291 -<div>Magic div</div>
 4291+<div style="/* insecure input */">Magic div</div>
42924292
42934293 !! end
42944294
@@ -4396,7 +4396,7 @@
43974397 !! input
43984398 <div style="<nowiki>border-left:expression(alert(document.cookie))</nowiki>"></div>
43994399 !! result
4400 -<div></div>
 4400+<div style="/* insecure input */"></div>
44014401
44024402 !! end
44034403
@@ -4416,7 +4416,7 @@
44174417 !! input
44184418 <div style="background-image:u\rl(javascript:alert('boo'))">evil</div>
44194419 !! result
4420 -<div>evil</div>
 4420+<div style="/* insecure input */">evil</div>
44214421
44224422 !! end
44234423
@@ -4425,7 +4425,7 @@
44264426 !! input
44274427 <div style="background-image:u\72l(javascript:alert('boo'))">evil</div>
44284428 !! result
4429 -<div>evil</div>
 4429+<div style="/* insecure input */">evil</div>
44304430
44314431 !! end
44324432
@@ -4471,7 +4471,7 @@
44724472 !! result
44734473 <table>
44744474 <tr>
4475 -<th> status
 4475+<th style="/* insecure input */"> status
44764476 </th></tr></table>
44774477
44784478 !! end
@@ -4481,7 +4481,7 @@
44824482 !! input
44834483 <div style="background-image: u\&#10;rl(test.jpg);"></div>
44844484 !! result
4485 -<div></div>
 4485+<div style="/* insecure input */"></div>
44864486
44874487 !! end
44884488
@@ -4490,7 +4490,7 @@
44914491 !! input
44924492 <div style="background-image: u\&#13;rl(test.jpg); "></div>
44934493 !! result
4494 -<div></div>
 4494+<div style="/* insecure input */"></div>
44954495
44964496 !! end
44974497

Follow-up revisions

RevisionCommit summaryAuthorDate
r67630MFT r67101 fixing in branch parser tests broken in r66990....platonides16:06, 8 June 2010
r69955MFT r67101. Fix parserTests broken r66992platonides18:38, 26 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66990Normalise CSS escape sequences.tstarling05:02, 28 May 2010

Status & tagging log