r67630 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67629‎ | r67630 | r67631 >
Date:16:06, 8 June 2010
Author:platonides
Status:ok
Tags:
Comment:
MFT r67101 fixing in branch parser tests broken in r66990.
Reported by freakolowsky on irc.
Modified paths:
  • /branches/REL1_16/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/maintenance/parserTests.txt
@@ -402,7 +402,7 @@
403403 !! input
404404 <pre width="8" style="border-width: expression(alert(document.cookie))">Narrow screen goodies</pre>
405405 !! result
406 -<pre width="8">Narrow screen goodies</pre>
 406+<pre width="8" style="/* insecure input */">Narrow screen goodies</pre>
407407
408408 !! end
409409
@@ -4231,7 +4231,7 @@
42324232 !! input
42334233 <div style="{{dangerous style attribute}}"></div>
42344234 !! result
4235 -<div></div>
 4235+<div style="/* insecure input */"></div>
42364236
42374237 !! end
42384238
@@ -4249,7 +4249,7 @@
42504250 !! input
42514251 {{div style|width: expression(alert(document.cookie))}}
42524252 !! result
4253 -<div>Magic div</div>
 4253+<div style="/* insecure input */">Magic div</div>
42544254
42554255 !! end
42564256
@@ -4358,7 +4358,7 @@
43594359 !! input
43604360 <div style="<nowiki>border-left:expression(alert(document.cookie))</nowiki>"></div>
43614361 !! result
4362 -<div></div>
 4362+<div style="/* insecure input */"></div>
43634363
43644364 !! end
43654365
@@ -4378,7 +4378,7 @@
43794379 !! input
43804380 <div style="background-image:u\rl(javascript:alert('boo'))">evil</div>
43814381 !! result
4382 -<div>evil</div>
 4382+<div style="/* insecure input */">evil</div>
43834383
43844384 !! end
43854385
@@ -4387,7 +4387,7 @@
43884388 !! input
43894389 <div style="background-image:u\72l(javascript:alert('boo'))">evil</div>
43904390 !! result
4391 -<div>evil</div>
 4391+<div style="/* insecure input */">evil</div>
43924392
43934393 !! end
43944394
@@ -4433,7 +4433,7 @@
44344434 !! result
44354435 <table>
44364436 <tr>
4437 -<th> status
 4437+<th style="/* insecure input */"> status
44384438 </th></tr></table>
44394439
44404440 !! end
@@ -4443,7 +4443,7 @@
44444444 !! input
44454445 <div style="background-image: u\&#10;rl(test.jpg);"></div>
44464446 !! result
4447 -<div></div>
 4447+<div style="/* insecure input */"></div>
44484448
44494449 !! end
44504450
@@ -4452,7 +4452,7 @@
44534453 !! input
44544454 <div style="background-image: u\&#13;rl(test.jpg); "></div>
44554455 !! result
4456 -<div></div>
 4456+<div style="/* insecure input */"></div>
44574457
44584458 !! end
44594459

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66990Normalise CSS escape sequences.tstarling05:02, 28 May 2010
r67101Follow up r66990. Fix parser tests.platonides18:59, 30 May 2010

Status & tagging log