r66836 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66835‎ | r66836 | r66837 >
Date:16:44, 24 May 2010
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
Merge r66835
Modified paths:
  • /branches/REL1_16/extensions/GroupsSidebar/GroupsSidebar.body.php (modified) (history)
  • /branches/REL1_16/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/extensions/GroupsSidebar/GroupsSidebar.body.php
@@ -11,7 +11,7 @@
1212 foreach ( $wgGroupsSidebar as $group => $sectiontitle ) {
1313 if (in_array($group, $wgUser->getEffectiveGroups())) {
1414 $message = 'sidebar-'.$sectiontitle;
15 - $skin->addToSidebar( &$bar, $message );
 15+ $skin->addToSidebar( $bar, wfMsgForContentNoTrans( $message ) );
1616 }
1717 }
1818 return true;
Index: branches/REL1_16/phase3/includes/Skin.php
@@ -2082,7 +2082,7 @@
20832083 }
20842084
20852085 $bar = array();
2086 - $this->addToSidebar( $bar, 'sidebar' );
 2086+ $this->addToSidebar( $bar, wfMsgForContentNoTrans( 'sidebar' ) );
20872087
20882088 wfRunHooks( 'SkinBuildSidebar', array( $this, &$bar ) );
20892089 if ( $wgEnableSidebarCache ) {
@@ -2091,15 +2091,17 @@
20922092 wfProfileOut( __METHOD__ );
20932093 return $bar;
20942094 }
 2095+
20952096 /**
2096 - * Add content from a sidebar system message
2097 - * Currently only used for MediaWiki:Sidebar (but may be used by Extensions)
2098 - *
 2097+ * Add content to the sidebar from text
 2098+ * @since 1.16
20992099 * @param &$bar array
2100 - * @param $message String
 2100+ * @param $text string
 2101+ *
 2102+ * @return array
21012103 */
2102 - function addToSidebar( &$bar, $message ) {
2103 - $lines = explode( "\n", wfMsgForContent( $message ) );
 2104+ function addToSidebar( &$bar, $text ) {
 2105+ $lines = explode( "\n", $text );
21042106 $heading = '';
21052107 foreach( $lines as $line ) {
21062108 if( strpos( $line, '*' ) !== 0 ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r68708Revert r66836, r66846 (equivalent to MFT r68707): it's too late to break inte...tstarling06:43, 29 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66835Follow up r62958. addToSidebar() was added in r59215, we still can redesign i...platonides16:38, 24 May 2010

Comments

#Comment by Tim Starling (talk | contribs)   06:21, 29 June 2010

Where are the release notes?

Status & tagging log