r66319 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66318‎ | r66319 | r66320 >
Date:00:30, 13 May 2010
Author:dale
Status:deferred
Tags:
Comment:
assign an id if video tag is missing one
some language updates
Modified paths:
  • /trunk/extensions/TimedMediaHandler/EmbedPlayer/EmbedPlayer.i18n.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/EmbedPlayer/loader.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/EmbedPlayer/mw.EmbedPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/EmbedPlayer/loader.js
@@ -79,7 +79,6 @@
8080 "vlcEmbed" : "vlcEmbed.js",
8181
8282 "ctrlBuilder" : "skins/ctrlBuilder.js",
83 - "mw.style.EmbedPlayer" : "mw.style.EmbedPlayer.css",
8483
8584 "mw.style.kskin" : "skins/kskin/EmbedPlayer.css",
8685 "kskinConfig" : "skins/kskin/kskinConfig.js",
@@ -174,8 +173,7 @@
175174 'ctrlBuilder',
176175 '$j.cookie',
177176 // Add JSON lib if browsers does not define "JSON" natively
178 - 'JSON',
179 - 'mw.style.EmbedPlayer'
 177+ 'JSON'
180178 ],
181179 [
182180 '$j.fn.menu',
Index: trunk/extensions/TimedMediaHandler/EmbedPlayer/mw.EmbedPlayer.js
@@ -341,7 +341,8 @@
342342 var _this = this;
343343
344344 if ( !element.id || element.id == '' ) {
345 - mw.log("Error: element is missing id ");
 345+ // give the element an id:
 346+ element.id = 'vid' + ( this.playerList.length + 1 );
346347 }
347348 mw.log('EmbedPlayerManager: addElement:: ' + element.id );
348349
@@ -947,7 +948,7 @@
948949 * @param {String} start_npt Start time in npt format
949950 * @param {String} end_npt End time in npt format
950951 */
951 - updateSourceTimes:function( start_npt, end_npt ) {
 952+ updateSourceTimes: function( start_npt, end_npt ) {
952953 var _this = this;
953954 $j.each( this.sources, function( inx, mediaSource ) {
954955 mediaSource.updateSrcTime( start_npt, end_npt );
Index: trunk/extensions/TimedMediaHandler/EmbedPlayer/EmbedPlayer.i18n.php
@@ -35,7 +35,7 @@
3636 'mwe-share' => 'Share',
3737 'mwe-credits' => 'Credits',
3838 'mwe-clip_linkback' => 'Clip source page',
39 - 'mwe-chose_player' => 'Chose video player',
 39+ 'mwe-chose_player' => 'Choose video player',
4040 'mwe-no-player' => 'No player available for $1',
4141 'mwe-share_this_video' => 'Share this video',
4242 'mwe-video_credits' => 'Video credits',
@@ -50,7 +50,7 @@
5151 'mwe-ogg-player-quicktime-activex' => 'QuickTime ActiveX',
5252 'mwe-ogg-player-cortado' => 'Java Cortado',
5353 'mwe-ogg-player-flowplayer' => 'Flowplayer',
54 - 'mwe-ogg-player-kplayer' => 'Kaltura flash player',
 54+ 'mwe-ogg-player-kplayer' => 'Kaltura player',
5555 'mwe-ogg-player-selected' => '(selected)',
5656 'mwe-ogg-player-omtkplayer' => 'OMTK Flash Vorbis',
5757 'mwe-generic_missing_plugin' => 'You browser does not appear to support the following playback type: <b>$1</b><br />Visit the <a href="http://commons.wikimedia.org/wiki/Commons:Media_help">Playback Methods</a> page to download a player.<br />',
@@ -66,6 +66,7 @@
6767 'mwe-video-flv' => 'Flash video',
6868 'mwe-video-ogg' => 'Ogg video',
6969 'mwe-video-audio' => 'Ogg audio',
 70+ 'mwe-missing-source' => 'No source video was found, check that your embed code includes a source or api key',
7071 );
7172 $messages['af'] = array(
7273 'mwe-credit-title' => 'Naam: $1',

Follow-up revisions

RevisionCommit summaryAuthorDate
r66339Follow-up r66319: update for translatewikiraymond13:06, 13 May 2010
r66347Follow-up r66319: Use consistent prefix 'mwe-embedplayer-...' to avoid confli...raymond14:51, 13 May 2010

Status & tagging log