r66939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66938‎ | r66939 | r66940 >
Date:00:42, 27 May 2010
Author:simetrical
Status:ok
Tags:
Comment:
Remove ‌ and   from trunk

See r66254 for context. I'm doing this separately because I need to
manually add comments, since I don't want to insert Unicode literals
that are just whitespace. Only one instance of each.
Modified paths:
  • /trunk/extensions/QPoll/qp_results.php (modified) (history)
  • /trunk/phase3/maintenance/fuzz-tester.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/fuzz-tester.php
@@ -454,8 +454,9 @@
455455 "|", // hex version.
456456 "ü", // malformed hex variant, MSB not zero.
457457
458 - // a "lignature" - http://www.robinlionheart.com/stds/html4/spchars#ligature
459 - "‌"
 458+ // a "lignature" - http://www.robinlionheart.com/stds/html4/spchars#ligature
 459+ // ‌ == ‌
 460+ "‌"
460461 );
461462
462463 // Defines various wiki-related bits of syntax, that can potentially cause
Index: trunk/extensions/QPoll/qp_results.php
@@ -402,7 +402,8 @@
403403 } else {
404404 $row = $qdata->Percents[ $propkey ];
405405 foreach ( $row as $catkey => &$cell ) {
406 - $formatted_cell = str_replace( " ", " ", sprintf( '%3d%%', intval( round( 100 * $cell ) ) ) );
 406+ # Replace spaces with en spaces
 407+ $formatted_cell = str_replace( " ", " ", sprintf( '%3d%%', intval( round( 100 * $cell ) ) ) );
407408 # only percents !=0 are displayed as link
408409 if ( $cell == 0.0 && $qdata->question_id !==null ) {
409410 $cell = array( 0=> $formatted_cell, "style"=>"color:gray" );
@@ -927,4 +928,4 @@
928929 }
929930 }
930931
931 -}
\ No newline at end of file
 932+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66254Remove most named character references from output...simetrical02:09, 12 May 2010

Status & tagging log