r66041 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66040‎ | r66041 | r66042 >
Date:19:10, 7 May 2010
Author:tomasz
Status:ok (Comments)
Tags:
Comment:
removing mysqldump locking
Modified paths:
  • /trunk/backup/worker.py (modified) (history)

Diff [purge]

Index: trunk/backup/worker.py
——@@ -90,7 +90,7 @@
9191
9292 def saveTable(self, table, outfile):
9393 """Dump a table from the current DB with mysqldump, save to a gzipped sql file."""
94 - command = "mysqldump -h %s -u %s %s --opt --quote-names %s %s | gzip" % shellEscape((
 94+ command = "mysqldump -h %s -u %s %s --extended-insert --skip-opt --quick --create-options --add-drop-table --extended-insert --set-charset --quote-names %s %s | gzip" % shellEscape((
9595 self.dbServer,
9696 self.config.dbUser,
9797 self.passwordOption(),

Follow-up revisions

RevisionCommit summaryAuthorDate
r69443re r66041: Simplify mysqldump command by using skip-* to specify the bits of ...mah21:22, 16 July 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   19:54, 16 July 2010

From the mysqldump man page: 

 To select the effect of --opt except for some features, use the --skip option
 for each feature. For example, to disable extended inserts and memory buffering,
 use --opt --skip-extended-insert --skip-quick. (As of MySQL 5.0, --skip-extended-insert
 --skip-quick is sufficient because --opt is on by default.)

Status & tagging log