r66040 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66039‎ | r66040 | r66041 >
Date:19:05, 7 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r66039
Modified paths:
  • /trunk/extensions/Storyboard/api/ApiQueryStories.php (modified) (history)
  • /trunk/extensions/Storyboard/tags/Storyboard/Storyboard_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/tags/Storyboard/Storyboard_body.php
@@ -64,7 +64,4 @@
6565 return array( $output, 'noparse' => true, 'isHTML' => true );
6666 }
6767
68 -}
69 -
70 -
71 -
 68+}
\ No newline at end of file
Index: trunk/extensions/Storyboard/api/ApiQueryStories.php
@@ -61,8 +61,12 @@
6262 'story_modified'
6363 ) );
6464
65 - $isReview = !is_null( $params['review'] ) && $wgUser->isAllowed( 'storyreview' );
 65+ $isReview = !is_null( $params['review'] );
6666
 67+ if ( $isReview && !$wgUser->isAllowed( 'storyreview' ) ) {
 68+ $this->dieUsageMsg( array( 'badaccess-groups' ) );
 69+ }
 70+
6771 if ( $isReview ) {
6872 if ( !isset( $params['state'] ) ) {
6973 $this->dieUsageMsg( array( 'missingparam', 'state' ) );
@@ -193,6 +197,7 @@
194198 */
195199 public function getPossibleErrors() {
196200 return array_merge( parent::getPossibleErrors(), array(
 201+ array( 'badaccess-groups' ),
197202 array( 'missingparam', 'state' ),
198203 ) );
199204 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66039Add missing errorreedy18:59, 7 May 2010

Status & tagging log