r65965 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r65964‎ \| r65965 \| r65966 >
Date:	21:42, 5 May 2010
Author:	tparscal
Status:	ok
Tags:
Comment:	Added versions to the URLs of all images in the Vector skin.
Modified paths:	/trunk/phase3/includes/DefaultSettings.php (modified) (history) /trunk/phase3/skins/vector/main-ltr.css (modified) (history) /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
—	—	@@ -25,13 +25,13 @@
26	26	}
27	27	body {
28	28	background-color: #f3f3f3;
29		~~- background-image: url(images/page-base.png);~~
	29	+ background-image: url(images/page-base.png?1);
30	30	}
31	31	/* Content */
32	32	#content {
33	33	margin-left: 10em;
34	34	padding: 1em;
35		~~- background-image: url(images/border.png);~~
	35	+ background-image: url(images/border.png?1);
36	36	background-position: top left;
37	37	background-repeat: repeat-y;
38	38	background-color: white;
—	—	@@ -41,7 +41,7 @@
42	42	#page-base {
43	43	height: 5em;
44	44	background-color: white;
45		~~- background-image: url(images/page-fade.png);~~
	45	+ background-image: url(images/page-fade.png?1);
46	46	background-position: bottom left;
47	47	background-repeat: repeat-x;
48	48	}
—	—	@@ -49,7 +49,7 @@
50	50	margin-top: -5em;
51	51	margin-left: 10em;
52	52	height: 5em;
53		~~- background-image: url(images/border.png);~~
	53	+ background-image: url(images/border.png?1);
54	54	background-position: bottom left;
55	55	background-repeat: repeat-x;
56	56	}
—	—	@@ -113,7 +113,7 @@
114	114	float: left;
115	115	}
116	116	div.vectorTabs {
117		~~- background-image: url(images/tab-break.png);~~
	117	+ background-image: url(images/tab-break.png?1);
118	118	background-position: bottom left;
119	119	background-repeat: no-repeat;
120	120	padding-left: 1px;
—	—	@@ -140,7 +140,7 @@
141	141	margin: 0;
142	142	padding: 0;
143	143	background-color: #f3f3f3;
144		~~- background-image: url(images/tab-normal-fade.png);~~
	144	+ background-image: url(images/tab-normal-fade.png?1);
145	145	background-position: bottom left;
146	146	background-repeat: repeat-x;
147	147	white-space:nowrap;
—	—	@@ -150,7 +150,7 @@
151	151	display: block;
152	152	}
153	153	div.vectorTabs li.selected {
154		~~- background-image: url(images/tab-current-fade.png);~~
	154	+ background-image: url(images/tab-current-fade.png?1);
155	155	}
156	156	/* OVERRIDDEN BY COMPLIANT BROWSERS */
157	157	div.vectorTabs li a {
—	—	@@ -158,7 +158,7 @@
159	159	height: 2.5em;
160	160	padding-left: 0.4em;
161	161	padding-right: 0.4em;
162		~~- background-image: url(images/tab-break.png);~~
	162	+ background-image: url(images/tab-break.png?1);
163	163	background-position: bottom right;
164	164	background-repeat: no-repeat;
165	165	}
—	—	@@ -203,7 +203,7 @@
204	204	div.vectorMenu {
205	205	direction: ltr;
206	206	float: left;
207		~~- background-image: url(images/arrow-down-icon.png);~~
	207	+ background-image: url(images/arrow-down-icon.png?1);
208	208	background-position: 100% 60%;
209	209	background-repeat: no-repeat;
210	210	cursor: pointer;
—	—	@@ -216,7 +216,7 @@
217	217	/* @noflip */
218	218	#head div.vectorMenu h5 {
219	219	float: left;
220		~~- background-image: url(images/tab-break.png);~~
	220	+ background-image: url(images/tab-break.png?1);
221	221	background-repeat: no-repeat;
222	222	}
223	223	/* IGNORED BY IE6 */
—	—	@@ -243,7 +243,7 @@
244	244	width: 24px;
245	245	height: 2.5em;
246	246	text-decoration: none;
247		~~- background-image: url(images/tab-break.png);~~
	247	+ background-image: url(images/tab-break.png?1);
248	248	background-repeat: no-repeat;
249	249	}
250	250	div.vectorMenu h5 a{
—	—	@@ -350,7 +350,7 @@
351	351	position: relative;
352	352	border: solid 1px #AAAAAA;
353	353	background-color: white;
354		~~- background-image: url(images/search-fade.png);~~
	354	+ background-image: url(images/search-fade.png?1);
355	355	background-position: top left;
356	356	background-repeat: repeat-x;
357	357	}
—	—	@@ -376,7 +376,7 @@
377	377	border: none;
378	378	cursor: pointer;
379	379	background-color: transparent;
380		~~- background-image: url(images/search-ltr.png);~~
	380	+ background-image: url(images/search-ltr.png?1);
381	381	background-position: center center;
382	382	background-repeat: no-repeat;
383	383	}
—	—	@@ -409,7 +409,7 @@
410	410	margin: 0;
411	411	padding-top: 0.5em;
412	412	margin-left: 1.25em;
413		~~- background-image: url(images/portal-break.png);~~
	413	+ background-image: url(images/portal-break.png?1);
414	414	background-repeat: no-repeat;
415	415	background-position: top left;
416	416	}
—	—	@@ -439,7 +439,7 @@
440	440	margin-left: 10em;
441	441	margin-top: 0;
442	442	padding: 0.75em;
443		~~- background-image: url(images/border.png);~~
	443	+ background-image: url(images/border.png?1);
444	444	background-position: top left;
445	445	background-repeat: repeat-x;
446	446	}
—	—	@@ -510,7 +510,7 @@
511	511	clear: both;
512	512	margin: 0 !important;
513	513	padding: 0 !important;
514		~~- background-image: url(images/preferences-break.png);~~
	514	+ background-image: url(images/preferences-break.png?1);
515	515	background-position: bottom left;
516	516	background-repeat: no-repeat;
517	517	}
—	—	@@ -524,7 +524,7 @@
525	525	white-space: nowrap;
526	526	list-style-type: none;
527	527	list-style-image: none;
528		~~- background-image: url(images/preferences-break.png);~~
	528	+ background-image: url(images/preferences-break.png?1);
529	529	background-position: bottom right;
530	530	background-repeat: no-repeat;
531	531	}
—	—	@@ -546,7 +546,7 @@
547	547	text-decoration: underline;
548	548	}
549	549	#preftoc li.selected a {
550		~~- background-image: url(images/preferences-fade.png);~~
	550	+ background-image: url(images/preferences-fade.png?1);
551	551	background-position: bottom;
552	552	background-repeat: repeat-x;
553	553	color: #333333;
—	—	@@ -560,7 +560,7 @@
561	561	clear: both;
562	562	border: solid 1px #cccccc;
563	563	background-color: #f9f9f9;
564		~~- background-image: url(images/preferences-base.png);~~
	564	+ background-image: url(images/preferences-base.png?1);
565	565	}
566	566	#preferences fieldset.prefsection {
567	567	border: none;
—	—	@@ -735,7 +735,7 @@
736	736	list-style-type: square;
737	737	margin: .3em 0 0 1.5em;
738	738	padding: 0;
739		~~- list-style-image: url(images/bullet-icon.png);~~
	739	+ list-style-image: url(images/bullet-icon.png?1);
740	740	}
741	741	ol {
742	742	line-height: 1.5em;
—	—	@@ -993,32 +993,32 @@
994	994	}
995	995	#content a.external,
996	996	#content a[href ^="gopher://"] {
997		~~- background: url(images/external-link-ltr-icon.png) center right no-repeat;~~
	997	+ background: url(images/external-link-ltr-icon.png?1) center right no-repeat;
998	998	padding: 0 13px 0 0;
999	999	}
1000	1000	#content a[href ^="https://"],
1001	1001	.link-https {
1002		~~- background: url(images/lock-icon.png) center right no-repeat;~~
	1002	+ background: url(images/lock-icon.png?1) center right no-repeat;
1003	1003	padding: 0 18px 0 0;
1004	1004	}
1005	1005	#content a[href ^="mailto:"],
1006	1006	.link-mailto {
1007		~~- background: url(images/mail-icon.png) center right no-repeat;~~
	1007	+ background: url(images/mail-icon.png?1) center right no-repeat;
1008	1008	padding: 0 18px 0 0;
1009	1009	}
1010	1010	#content a[href ^="news://"] {
1011		~~- background: url(images/news-icon.png) center right no-repeat;~~
	1011	+ background: url(images/news-icon.png?1) center right no-repeat;
1012	1012	padding: 0 18px 0 0;
1013	1013	}
1014	1014	#content a[href ^="ftp://"],
1015	1015	.link-ftp {
1016		~~- background: url(images/file-icon.png) center right no-repeat;~~
	1016	+ background: url(images/file-icon.png?1) center right no-repeat;
1017	1017	padding: 0 18px 0 0;
1018	1018	}
1019	1019	#content a[href ^="irc://"],
1020	1020	#content a.extiw[href ^="irc://"],
1021	1021	.link-irc {
1022		~~- background: url(images/talk-icon.png) center right no-repeat;~~
	1022	+ background: url(images/talk-icon.png?1) center right no-repeat;
1023	1023	padding: 0 18px 0 0;
1024	1024	}
1025	1025	#content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
—	—	@@ -1063,7 +1063,7 @@
1064	1064	#pt-userpage,
1065	1065	#pt-anonuserpage,
1066	1066	#pt-login {
1067		~~- background: url(images/user-icon.png) left top no-repeat;~~
	1067	+ background: url(images/user-icon.png?1) left top no-repeat;
1068	1068	padding-left: 15px !important;
1069	1069	text-transform: none;
1070	1070	}
—	—	@@ -1100,24 +1100,24 @@
1101	1101	height: 2.5em;
1102	1102	}
1103	1103	#ca-unwatch.icon a {
1104		~~- background-image: url(images/watch-icons.png);~~
	1104	+ background-image: url(images/watch-icons.png?1);
1105	1105	background-position: -43px 60%;
1106	1106	}
1107	1107	#ca-watch.icon a {
1108		~~- background-image: url(images/watch-icons.png);~~
	1108	+ background-image: url(images/watch-icons.png?1);
1109	1109	background-position: 5px 60%;
1110	1110	}
1111	1111	#ca-unwatch.icon a:hover {
1112		~~- background-image: url(images/watch-icons.png);~~
	1112	+ background-image: url(images/watch-icons.png?1);
1113	1113	background-position: -67px 60%;
1114	1114	}
1115	1115	#ca-watch.icon a:hover {
1116		~~- background-image: url(images/watch-icons.png);~~
	1116	+ background-image: url(images/watch-icons.png?1);
1117	1117	background-position: -19px 60%;
1118	1118	}
1119	1119	#ca-unwatch.icon a.loading,
1120	1120	#ca-watch.icon a.loading {
1121		~~- background-image: url(images/watch-icon-loading.gif);~~
	1121	+ background-image: url(images/watch-icon-loading.gif?1);
1122	1122	background-position: center 60%;
1123	1123	}
1124	1124	#ca-unwatch.icon a span,
—	—	@@ -1125,7 +1125,7 @@
1126	1126	display: none;
1127	1127	}
1128	1128	div.vectorTabs ul {
1129		~~- background-image:url(images/tab-break.png);~~
	1129	+ background-image:url(images/tab-break.png?1);
1130	1130	background-position:right bottom;
1131	1131	background-repeat:no-repeat;
1132	1132	}
\ No newline at end of file
Index: trunk/phase3/skins/vector/main-rtl.css
—	—	@@ -25,13 +25,13 @@
26	26	}
27	27	body {
28	28	background-color: #f3f3f3;
29		~~- background-image: url(images/page-base.png);~~
	29	+ background-image: url(images/page-base.png?1);
30	30	}
31	31	/* Content */
32	32	#content {
33	33	margin-right: 10em;
34	34	padding: 1em;
35		~~- background-image: url(images/border.png);~~
	35	+ background-image: url(images/border.png?1);
36	36	background-position: top right;
37	37	background-repeat: repeat-y;
38	38	background-color: white;
—	—	@@ -41,7 +41,7 @@
42	42	#page-base {
43	43	height: 5em;
44	44	background-color: white;
45		~~- background-image: url(images/page-fade.png);~~
	45	+ background-image: url(images/page-fade.png?1);
46	46	background-position: bottom right;
47	47	background-repeat: repeat-x;
48	48	}
—	—	@@ -49,7 +49,7 @@
50	50	margin-top: -5em;
51	51	margin-right: 10em;
52	52	height: 5em;
53		~~- background-image: url(images/border.png);~~
	53	+ background-image: url(images/border.png?1);
54	54	background-position: bottom right;
55	55	background-repeat: repeat-x;
56	56	}
—	—	@@ -113,7 +113,7 @@
114	114	float: left;
115	115	}
116	116	div.vectorTabs {
117		~~- background-image: url(images/tab-break.png);~~
	117	+ background-image: url(images/tab-break.png?1);
118	118	background-position: bottom right;
119	119	background-repeat: no-repeat;
120	120	padding-right: 1px;
—	—	@@ -140,7 +140,7 @@
141	141	margin: 0;
142	142	padding: 0;
143	143	background-color: #f3f3f3;
144		~~- background-image: url(images/tab-normal-fade.png);~~
	144	+ background-image: url(images/tab-normal-fade.png?1);
145	145	background-position: bottom right;
146	146	background-repeat: repeat-x;
147	147	white-space:nowrap;
—	—	@@ -150,7 +150,7 @@
151	151	display: block;
152	152	}
153	153	div.vectorTabs li.selected {
154		~~- background-image: url(images/tab-current-fade.png);~~
	154	+ background-image: url(images/tab-current-fade.png?1);
155	155	}
156	156	/* OVERRIDDEN BY COMPLIANT BROWSERS */
157	157	div.vectorTabs li a {
—	—	@@ -158,7 +158,7 @@
159	159	height: 2.5em;
160	160	padding-right: 0.4em;
161	161	padding-left: 0.4em;
162		~~- background-image: url(images/tab-break.png);~~
	162	+ background-image: url(images/tab-break.png?1);
163	163	background-position: bottom left;
164	164	background-repeat: no-repeat;
165	165	}
—	—	@@ -203,7 +203,7 @@
204	204	div.vectorMenu {
205	205	direction: ltr;
206	206	float: left;
207		~~- background-image: url(images/arrow-down-icon.png);~~
	207	+ background-image: url(images/arrow-down-icon.png?1);
208	208	background-position: 100% 60%;
209	209	background-repeat: no-repeat;
210	210	cursor: pointer;
—	—	@@ -216,7 +216,7 @@
217	217	/* @noflip */
218	218	#head div.vectorMenu h5 {
219	219	float: left;
220		~~- background-image: url(images/tab-break.png);~~
	220	+ background-image: url(images/tab-break.png?1);
221	221	background-repeat: no-repeat;
222	222	}
223	223	/* IGNORED BY IE6 */
—	—	@@ -243,7 +243,7 @@
244	244	width: 24px;
245	245	height: 2.5em;
246	246	text-decoration: none;
247		~~- background-image: url(images/tab-break.png);~~
	247	+ background-image: url(images/tab-break.png?1);
248	248	background-repeat: no-repeat;
249	249	}
250	250	div.vectorMenu h5 a{
—	—	@@ -350,7 +350,7 @@
351	351	position: relative;
352	352	border: solid 1px #AAAAAA;
353	353	background-color: white;
354		~~- background-image: url(images/search-fade.png);~~
	354	+ background-image: url(images/search-fade.png?1);
355	355	background-position: top right;
356	356	background-repeat: repeat-x;
357	357	}
—	—	@@ -376,7 +376,7 @@
377	377	border: none;
378	378	cursor: pointer;
379	379	background-color: transparent;
380		~~- background-image: url(images/search-rtl.png);~~
	380	+ background-image: url(images/search-rtl.png?1);
381	381	background-position: center center;
382	382	background-repeat: no-repeat;
383	383	}
—	—	@@ -409,7 +409,7 @@
410	410	margin: 0;
411	411	padding-top: 0.5em;
412	412	margin-right: 1.25em;
413		~~- background-image: url(images/portal-break.png);~~
	413	+ background-image: url(images/portal-break.png?1);
414	414	background-repeat: no-repeat;
415	415	background-position: top right;
416	416	}
—	—	@@ -439,7 +439,7 @@
440	440	margin-right: 10em;
441	441	margin-top: 0;
442	442	padding: 0.75em;
443		~~- background-image: url(images/border.png);~~
	443	+ background-image: url(images/border.png?1);
444	444	background-position: top right;
445	445	background-repeat: repeat-x;
446	446	}
—	—	@@ -510,7 +510,7 @@
511	511	clear: both;
512	512	margin: 0 !important;
513	513	padding: 0 !important;
514		~~- background-image: url(images/preferences-break.png);~~
	514	+ background-image: url(images/preferences-break.png?1);
515	515	background-position: bottom right;
516	516	background-repeat: no-repeat;
517	517	}
—	—	@@ -524,7 +524,7 @@
525	525	white-space: nowrap;
526	526	list-style-type: none;
527	527	list-style-image: none;
528		~~- background-image: url(images/preferences-break.png);~~
	528	+ background-image: url(images/preferences-break.png?1);
529	529	background-position: bottom left;
530	530	background-repeat: no-repeat;
531	531	}
—	—	@@ -546,7 +546,7 @@
547	547	text-decoration: underline;
548	548	}
549	549	#preftoc li.selected a {
550		~~- background-image: url(images/preferences-fade.png);~~
	550	+ background-image: url(images/preferences-fade.png?1);
551	551	background-position: bottom;
552	552	background-repeat: repeat-x;
553	553	color: #333333;
—	—	@@ -560,7 +560,7 @@
561	561	clear: both;
562	562	border: solid 1px #cccccc;
563	563	background-color: #f9f9f9;
564		~~- background-image: url(images/preferences-base.png);~~
	564	+ background-image: url(images/preferences-base.png?1);
565	565	}
566	566	#preferences fieldset.prefsection {
567	567	border: none;
—	—	@@ -735,7 +735,7 @@
736	736	list-style-type: square;
737	737	margin: .3em 1.5em 0 0;
738	738	padding: 0;
739		~~- list-style-image: url(images/bullet-icon.png);~~
	739	+ list-style-image: url(images/bullet-icon.png?1);
740	740	}
741	741	ol {
742	742	line-height: 1.5em;
—	—	@@ -993,32 +993,32 @@
994	994	}
995	995	#content a.external,
996	996	#content a[href ^="gopher://"] {
997		~~- background: url(images/external-link-rtl-icon.png) center left no-repeat;~~
	997	+ background: url(images/external-link-rtl-icon.png?1) center left no-repeat;
998	998	padding: 0 0 0 13px;
999	999	}
1000	1000	#content a[href ^="https://"],
1001	1001	.link-https {
1002		~~- background: url(images/lock-icon.png) center left no-repeat;~~
	1002	+ background: url(images/lock-icon.png?1) center left no-repeat;
1003	1003	padding: 0 0 0 18px;
1004	1004	}
1005	1005	#content a[href ^="mailto:"],
1006	1006	.link-mailto {
1007		~~- background: url(images/mail-icon.png) center left no-repeat;~~
	1007	+ background: url(images/mail-icon.png?1) center left no-repeat;
1008	1008	padding: 0 0 0 18px;
1009	1009	}
1010	1010	#content a[href ^="news://"] {
1011		~~- background: url(images/news-icon.png) center left no-repeat;~~
	1011	+ background: url(images/news-icon.png?1) center left no-repeat;
1012	1012	padding: 0 0 0 18px;
1013	1013	}
1014	1014	#content a[href ^="ftp://"],
1015	1015	.link-ftp {
1016		~~- background: url(images/file-icon.png) center left no-repeat;~~
	1016	+ background: url(images/file-icon.png?1) center left no-repeat;
1017	1017	padding: 0 0 0 18px;
1018	1018	}
1019	1019	#content a[href ^="irc://"],
1020	1020	#content a.extiw[href ^="irc://"],
1021	1021	.link-irc {
1022		~~- background: url(images/talk-icon.png) center left no-repeat;~~
	1022	+ background: url(images/talk-icon.png?1) center left no-repeat;
1023	1023	padding: 0 0 0 18px;
1024	1024	}
1025	1025	#content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
—	—	@@ -1063,7 +1063,7 @@
1064	1064	#pt-userpage,
1065	1065	#pt-anonuserpage,
1066	1066	#pt-login {
1067		~~- background: url(images/user-icon.png) right top no-repeat;~~
	1067	+ background: url(images/user-icon.png?1) right top no-repeat;
1068	1068	padding-right: 15px !important;
1069	1069	text-transform: none;
1070	1070	}
—	—	@@ -1100,24 +1100,24 @@
1101	1101	height: 2.5em;
1102	1102	}
1103	1103	#ca-unwatch.icon a {
1104		~~- background-image: url(images/watch-icons.png);~~
	1104	+ background-image: url(images/watch-icons.png?1);
1105	1105	background-position: -43px 60%;
1106	1106	}
1107	1107	#ca-watch.icon a {
1108		~~- background-image: url(images/watch-icons.png);~~
	1108	+ background-image: url(images/watch-icons.png?1);
1109	1109	background-position: 5px 60%;
1110	1110	}
1111	1111	#ca-unwatch.icon a:hover {
1112		~~- background-image: url(images/watch-icons.png);~~
	1112	+ background-image: url(images/watch-icons.png?1);
1113	1113	background-position: -67px 60%;
1114	1114	}
1115	1115	#ca-watch.icon a:hover {
1116		~~- background-image: url(images/watch-icons.png);~~
	1116	+ background-image: url(images/watch-icons.png?1);
1117	1117	background-position: -19px 60%;
1118	1118	}
1119	1119	#ca-unwatch.icon a.loading,
1120	1120	#ca-watch.icon a.loading {
1121		~~- background-image: url(images/watch-icon-loading.gif);~~
	1121	+ background-image: url(images/watch-icon-loading.gif?1);
1122	1122	background-position: center 60%;
1123	1123	}
1124	1124	#ca-unwatch.icon a span,
—	—	@@ -1125,7 +1125,7 @@
1126	1126	display: none;
1127	1127	}
1128	1128	div.vectorTabs ul {
1129		~~- background-image:url(images/tab-break.png);~~
	1129	+ background-image:url(images/tab-break.png?1);
1130	1130	background-position:left bottom;
1131	1131	background-repeat:no-repeat;
1132	1132	}
\ No newline at end of file
Index: trunk/phase3/includes/DefaultSettings.php
—	—	@@ -1683,7 +1683,7 @@
1684	1684	* to ensure that client-side caches do not keep obsolete copies of global
1685	1685	* styles.
1686	1686	*/
1687		~~-$wgStyleVersion = '275';~~
	1687	+$wgStyleVersion = '276';
1688	1688
1689	1689
1690	1690	# Server-side caching:

Follow-up revisions

Revision	Commit summary	Author	Date
r65966	1.16wmf4: MFT r65965	catrope	21:55, 5 May 2010

Status & tagging log

12:41, 6 May 2010 Catrope (talk | contribs) changed the status of r65965 [removed: new added: ok]