r65966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65965‎ | r65966 | r65967 >
Date:21:55, 5 May 2010
Author:catrope
Status:deferred
Tags:
Comment:
1.16wmf4: MFT r65965
Modified paths:
  • /branches/wmf/1.16wmf4/includes/DefaultSettings.php (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/main-ltr.css (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/skins/vector/main-ltr.css
@@ -25,13 +25,13 @@
2626 }
2727 body {
2828 background-color: #f3f3f3;
29 - background-image: url(images/page-base.png);
 29+ background-image: url(images/page-base.png?1);
3030 }
3131 /* Content */
3232 #content {
3333 margin-left: 10em;
3434 padding: 1em;
35 - background-image: url(images/border.png);
 35+ background-image: url(images/border.png?1);
3636 background-position: top left;
3737 background-repeat: repeat-y;
3838 background-color: white;
@@ -40,7 +40,7 @@
4141 #page-base {
4242 height: 5em;
4343 background-color: white;
44 - background-image: url(images/page-fade.png);
 44+ background-image: url(images/page-fade.png?1);
4545 background-position: bottom left;
4646 background-repeat: repeat-x;
4747 }
@@ -48,7 +48,7 @@
4949 margin-top: -5em;
5050 margin-left: 10em;
5151 height: 5em;
52 - background-image: url(images/border.png);
 52+ background-image: url(images/border.png?1);
5353 background-position: bottom left;
5454 background-repeat: repeat-x;
5555 }
@@ -112,7 +112,7 @@
113113 float: left;
114114 }
115115 div.vectorTabs {
116 - background-image: url(images/tab-break.png);
 116+ background-image: url(images/tab-break.png?1);
117117 background-position: bottom left;
118118 background-repeat: no-repeat;
119119 padding-left: 1px;
@@ -139,7 +139,7 @@
140140 margin: 0;
141141 padding: 0;
142142 background-color: #f3f3f3;
143 - background-image: url(images/tab-normal-fade.png);
 143+ background-image: url(images/tab-normal-fade.png?1);
144144 background-position: bottom left;
145145 background-repeat: repeat-x;
146146 white-space:nowrap;
@@ -149,7 +149,7 @@
150150 display: block;
151151 }
152152 div.vectorTabs li.selected {
153 - background-image: url(images/tab-current-fade.png);
 153+ background-image: url(images/tab-current-fade.png?1);
154154 }
155155 /* OVERRIDDEN BY COMPLIANT BROWSERS */
156156 div.vectorTabs li a {
@@ -157,7 +157,7 @@
158158 height: 2.5em;
159159 padding-left: 0.4em;
160160 padding-right: 0.4em;
161 - background-image: url(images/tab-break.png);
 161+ background-image: url(images/tab-break.png?1);
162162 background-position: bottom right;
163163 background-repeat: no-repeat;
164164 }
@@ -202,7 +202,7 @@
203203 div.vectorMenu {
204204 direction: ltr;
205205 float: left;
206 - background-image: url(images/arrow-down-icon.png);
 206+ background-image: url(images/arrow-down-icon.png?1);
207207 background-position: 100% 60%;
208208 background-repeat: no-repeat;
209209 cursor: pointer;
@@ -215,7 +215,7 @@
216216 /* @noflip */
217217 #head div.vectorMenu h5 {
218218 float: left;
219 - background-image: url(images/tab-break.png);
 219+ background-image: url(images/tab-break.png?1);
220220 background-repeat: no-repeat;
221221 }
222222 /* IGNORED BY IE6 */
@@ -242,7 +242,7 @@
243243 width: 24px;
244244 height: 2.5em;
245245 text-decoration: none;
246 - background-image: url(images/tab-break.png);
 246+ background-image: url(images/tab-break.png?1);
247247 background-repeat: no-repeat;
248248 }
249249 div.vectorMenu h5 a{
@@ -349,7 +349,7 @@
350350 position: relative;
351351 border: solid 1px #AAAAAA;
352352 background-color: white;
353 - background-image: url(images/search-fade.png);
 353+ background-image: url(images/search-fade.png?1);
354354 background-position: top left;
355355 background-repeat: repeat-x;
356356 }
@@ -375,7 +375,7 @@
376376 border: none;
377377 cursor: pointer;
378378 background-color: transparent;
379 - background-image: url(images/search-ltr.png);
 379+ background-image: url(images/search-ltr.png?1);
380380 background-position: center center;
381381 background-repeat: no-repeat;
382382 }
@@ -419,7 +419,7 @@
420420 margin: 0;
421421 padding-top: 0.5em;
422422 margin-left: 1.25em;
423 - background-image: url(images/portal-break.png);
 423+ background-image: url(images/portal-break.png?1);
424424 background-repeat: no-repeat;
425425 background-position: top left;
426426 }
@@ -449,7 +449,7 @@
450450 margin-left: 10em;
451451 margin-top: 0;
452452 padding: 0.75em;
453 - background-image: url(images/border.png);
 453+ background-image: url(images/border.png?1);
454454 background-position: top left;
455455 background-repeat: repeat-x;
456456 }
@@ -520,7 +520,7 @@
521521 clear: both;
522522 margin: 0 !important;
523523 padding: 0 !important;
524 - background-image: url(images/preferences-break.png);
 524+ background-image: url(images/preferences-break.png?1);
525525 background-position: bottom left;
526526 background-repeat: no-repeat;
527527 }
@@ -534,7 +534,7 @@
535535 white-space: nowrap;
536536 list-style-type: none;
537537 list-style-image: none;
538 - background-image: url(images/preferences-break.png);
 538+ background-image: url(images/preferences-break.png?1);
539539 background-position: bottom right;
540540 background-repeat: no-repeat;
541541 }
@@ -556,7 +556,7 @@
557557 text-decoration: underline;
558558 }
559559 #preftoc li.selected a {
560 - background-image: url(images/preferences-fade.png);
 560+ background-image: url(images/preferences-fade.png?1);
561561 background-position: bottom;
562562 background-repeat: repeat-x;
563563 color: #333333;
@@ -570,7 +570,7 @@
571571 clear: both;
572572 border: solid 1px #cccccc;
573573 background-color: #f9f9f9;
574 - background-image: url(images/preferences-base.png);
 574+ background-image: url(images/preferences-base.png?1);
575575 }
576576 #preferences fieldset.prefsection {
577577 border: none;
@@ -745,7 +745,7 @@
746746 list-style-type: square;
747747 margin: .3em 0 0 1.5em;
748748 padding: 0;
749 - list-style-image: url(images/bullet-icon.png);
 749+ list-style-image: url(images/bullet-icon.png?1);
750750 }
751751 ol {
752752 line-height: 1.5em;
@@ -1003,32 +1003,32 @@
10041004 }
10051005 #content a.external,
10061006 #content a[href ^="gopher://"] {
1007 - background: url(images/external-link-ltr-icon.png) center right no-repeat;
 1007+ background: url(images/external-link-ltr-icon.png?1) center right no-repeat;
10081008 padding: 0 13px 0 0;
10091009 }
10101010 #content a[href ^="https://"],
10111011 .link-https {
1012 - background: url(images/lock-icon.png) center right no-repeat;
 1012+ background: url(images/lock-icon.png?1) center right no-repeat;
10131013 padding: 0 18px 0 0;
10141014 }
10151015 #content a[href ^="mailto:"],
10161016 .link-mailto {
1017 - background: url(images/mail-icon.png) center right no-repeat;
 1017+ background: url(images/mail-icon.png?1) center right no-repeat;
10181018 padding: 0 18px 0 0;
10191019 }
10201020 #content a[href ^="news://"] {
1021 - background: url(images/news-icon.png) center right no-repeat;
 1021+ background: url(images/news-icon.png?1) center right no-repeat;
10221022 padding: 0 18px 0 0;
10231023 }
10241024 #content a[href ^="ftp://"],
10251025 .link-ftp {
1026 - background: url(images/file-icon.png) center right no-repeat;
 1026+ background: url(images/file-icon.png?1) center right no-repeat;
10271027 padding: 0 18px 0 0;
10281028 }
10291029 #content a[href ^="irc://"],
10301030 #content a.extiw[href ^="irc://"],
10311031 .link-irc {
1032 - background: url(images/talk-icon.png) center right no-repeat;
 1032+ background: url(images/talk-icon.png?1) center right no-repeat;
10331033 padding: 0 18px 0 0;
10341034 }
10351035 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
@@ -1073,7 +1073,7 @@
10741074 #pt-userpage,
10751075 #pt-anonuserpage,
10761076 #pt-login {
1077 - background: url(images/user-icon.png) left top no-repeat;
 1077+ background: url(images/user-icon.png?1) left top no-repeat;
10781078 padding-left: 15px !important;
10791079 text-transform: none;
10801080 }
@@ -1110,24 +1110,24 @@
11111111 height: 2.5em;
11121112 }
11131113 #ca-unwatch.icon a {
1114 - background-image: url(images/watch-icons.png);
 1114+ background-image: url(images/watch-icons.png?1);
11151115 background-position: -43px 60%;
11161116 }
11171117 #ca-watch.icon a {
1118 - background-image: url(images/watch-icons.png);
 1118+ background-image: url(images/watch-icons.png?1);
11191119 background-position: 5px 60%;
11201120 }
11211121 #ca-unwatch.icon a:hover {
1122 - background-image: url(images/watch-icons.png);
 1122+ background-image: url(images/watch-icons.png?1);
11231123 background-position: -67px 60%;
11241124 }
11251125 #ca-watch.icon a:hover {
1126 - background-image: url(images/watch-icons.png);
 1126+ background-image: url(images/watch-icons.png?1);
11271127 background-position: -19px 60%;
11281128 }
11291129 #ca-unwatch.icon a.loading,
11301130 #ca-watch.icon a.loading {
1131 - background-image: url(images/watch-icon-loading.gif);
 1131+ background-image: url(images/watch-icon-loading.gif?1);
11321132 background-position: center 60%;
11331133 }
11341134 #ca-unwatch.icon a span,
@@ -1135,7 +1135,7 @@
11361136 display: none;
11371137 }
11381138 div.vectorTabs ul {
1139 - background-image:url(images/tab-break.png);
 1139+ background-image:url(images/tab-break.png?1);
11401140 background-position:right bottom;
11411141 background-repeat:no-repeat;
11421142 }
\ No newline at end of file
Index: branches/wmf/1.16wmf4/skins/vector/main-rtl.css
@@ -25,13 +25,13 @@
2626 }
2727 body {
2828 background-color: #f3f3f3;
29 - background-image: url(images/page-base.png);
 29+ background-image: url(images/page-base.png?1);
3030 }
3131 /* Content */
3232 #content {
3333 margin-right: 10em;
3434 padding: 1em;
35 - background-image: url(images/border.png);
 35+ background-image: url(images/border.png?1);
3636 background-position: top right;
3737 background-repeat: repeat-y;
3838 background-color: white;
@@ -40,7 +40,7 @@
4141 #page-base {
4242 height: 5em;
4343 background-color: white;
44 - background-image: url(images/page-fade.png);
 44+ background-image: url(images/page-fade.png?1);
4545 background-position: bottom right;
4646 background-repeat: repeat-x;
4747 }
@@ -48,7 +48,7 @@
4949 margin-top: -5em;
5050 margin-right: 10em;
5151 height: 5em;
52 - background-image: url(images/border.png);
 52+ background-image: url(images/border.png?1);
5353 background-position: bottom right;
5454 background-repeat: repeat-x;
5555 }
@@ -112,7 +112,7 @@
113113 float: left;
114114 }
115115 div.vectorTabs {
116 - background-image: url(images/tab-break.png);
 116+ background-image: url(images/tab-break.png?1);
117117 background-position: bottom right;
118118 background-repeat: no-repeat;
119119 padding-right: 1px;
@@ -139,7 +139,7 @@
140140 margin: 0;
141141 padding: 0;
142142 background-color: #f3f3f3;
143 - background-image: url(images/tab-normal-fade.png);
 143+ background-image: url(images/tab-normal-fade.png?1);
144144 background-position: bottom right;
145145 background-repeat: repeat-x;
146146 white-space:nowrap;
@@ -149,7 +149,7 @@
150150 display: block;
151151 }
152152 div.vectorTabs li.selected {
153 - background-image: url(images/tab-current-fade.png);
 153+ background-image: url(images/tab-current-fade.png?1);
154154 }
155155 /* OVERRIDDEN BY COMPLIANT BROWSERS */
156156 div.vectorTabs li a {
@@ -157,7 +157,7 @@
158158 height: 2.5em;
159159 padding-right: 0.4em;
160160 padding-left: 0.4em;
161 - background-image: url(images/tab-break.png);
 161+ background-image: url(images/tab-break.png?1);
162162 background-position: bottom left;
163163 background-repeat: no-repeat;
164164 }
@@ -202,7 +202,7 @@
203203 div.vectorMenu {
204204 direction: ltr;
205205 float: left;
206 - background-image: url(images/arrow-down-icon.png);
 206+ background-image: url(images/arrow-down-icon.png?1);
207207 background-position: 100% 60%;
208208 background-repeat: no-repeat;
209209 cursor: pointer;
@@ -215,7 +215,7 @@
216216 /* @noflip */
217217 #head div.vectorMenu h5 {
218218 float: left;
219 - background-image: url(images/tab-break.png);
 219+ background-image: url(images/tab-break.png?1);
220220 background-repeat: no-repeat;
221221 }
222222 /* IGNORED BY IE6 */
@@ -242,7 +242,7 @@
243243 width: 24px;
244244 height: 2.5em;
245245 text-decoration: none;
246 - background-image: url(images/tab-break.png);
 246+ background-image: url(images/tab-break.png?1);
247247 background-repeat: no-repeat;
248248 }
249249 div.vectorMenu h5 a{
@@ -349,7 +349,7 @@
350350 position: relative;
351351 border: solid 1px #AAAAAA;
352352 background-color: white;
353 - background-image: url(images/search-fade.png);
 353+ background-image: url(images/search-fade.png?1);
354354 background-position: top right;
355355 background-repeat: repeat-x;
356356 }
@@ -375,7 +375,7 @@
376376 border: none;
377377 cursor: pointer;
378378 background-color: transparent;
379 - background-image: url(images/search-rtl.png);
 379+ background-image: url(images/search-rtl.png?1);
380380 background-position: center center;
381381 background-repeat: no-repeat;
382382 }
@@ -419,7 +419,7 @@
420420 margin: 0;
421421 padding-top: 0.5em;
422422 margin-right: 1.25em;
423 - background-image: url(images/portal-break.png);
 423+ background-image: url(images/portal-break.png?1);
424424 background-repeat: no-repeat;
425425 background-position: top right;
426426 }
@@ -449,7 +449,7 @@
450450 margin-right: 10em;
451451 margin-top: 0;
452452 padding: 0.75em;
453 - background-image: url(images/border.png);
 453+ background-image: url(images/border.png?1);
454454 background-position: top right;
455455 background-repeat: repeat-x;
456456 }
@@ -520,7 +520,7 @@
521521 clear: both;
522522 margin: 0 !important;
523523 padding: 0 !important;
524 - background-image: url(images/preferences-break.png);
 524+ background-image: url(images/preferences-break.png?1);
525525 background-position: bottom right;
526526 background-repeat: no-repeat;
527527 }
@@ -534,7 +534,7 @@
535535 white-space: nowrap;
536536 list-style-type: none;
537537 list-style-image: none;
538 - background-image: url(images/preferences-break.png);
 538+ background-image: url(images/preferences-break.png?1);
539539 background-position: bottom left;
540540 background-repeat: no-repeat;
541541 }
@@ -556,7 +556,7 @@
557557 text-decoration: underline;
558558 }
559559 #preftoc li.selected a {
560 - background-image: url(images/preferences-fade.png);
 560+ background-image: url(images/preferences-fade.png?1);
561561 background-position: bottom;
562562 background-repeat: repeat-x;
563563 color: #333333;
@@ -570,7 +570,7 @@
571571 clear: both;
572572 border: solid 1px #cccccc;
573573 background-color: #f9f9f9;
574 - background-image: url(images/preferences-base.png);
 574+ background-image: url(images/preferences-base.png?1);
575575 }
576576 #preferences fieldset.prefsection {
577577 border: none;
@@ -745,7 +745,7 @@
746746 list-style-type: square;
747747 margin: .3em 1.5em 0 0;
748748 padding: 0;
749 - list-style-image: url(images/bullet-icon.png);
 749+ list-style-image: url(images/bullet-icon.png?1);
750750 }
751751 ol {
752752 line-height: 1.5em;
@@ -1003,32 +1003,32 @@
10041004 }
10051005 #content a.external,
10061006 #content a[href ^="gopher://"] {
1007 - background: url(images/external-link-rtl-icon.png) center left no-repeat;
 1007+ background: url(images/external-link-rtl-icon.png?1) center left no-repeat;
10081008 padding: 0 0 0 13px;
10091009 }
10101010 #content a[href ^="https://"],
10111011 .link-https {
1012 - background: url(images/lock-icon.png) center left no-repeat;
 1012+ background: url(images/lock-icon.png?1) center left no-repeat;
10131013 padding: 0 0 0 18px;
10141014 }
10151015 #content a[href ^="mailto:"],
10161016 .link-mailto {
1017 - background: url(images/mail-icon.png) center left no-repeat;
 1017+ background: url(images/mail-icon.png?1) center left no-repeat;
10181018 padding: 0 0 0 18px;
10191019 }
10201020 #content a[href ^="news://"] {
1021 - background: url(images/news-icon.png) center left no-repeat;
 1021+ background: url(images/news-icon.png?1) center left no-repeat;
10221022 padding: 0 0 0 18px;
10231023 }
10241024 #content a[href ^="ftp://"],
10251025 .link-ftp {
1026 - background: url(images/file-icon.png) center left no-repeat;
 1026+ background: url(images/file-icon.png?1) center left no-repeat;
10271027 padding: 0 0 0 18px;
10281028 }
10291029 #content a[href ^="irc://"],
10301030 #content a.extiw[href ^="irc://"],
10311031 .link-irc {
1032 - background: url(images/talk-icon.png) center left no-repeat;
 1032+ background: url(images/talk-icon.png?1) center left no-repeat;
10331033 padding: 0 0 0 18px;
10341034 }
10351035 #content a.external[href $=".ogg"], #content a.external[href $=".OGG"],
@@ -1073,7 +1073,7 @@
10741074 #pt-userpage,
10751075 #pt-anonuserpage,
10761076 #pt-login {
1077 - background: url(images/user-icon.png) right top no-repeat;
 1077+ background: url(images/user-icon.png?1) right top no-repeat;
10781078 padding-right: 15px !important;
10791079 text-transform: none;
10801080 }
@@ -1110,24 +1110,24 @@
11111111 height: 2.5em;
11121112 }
11131113 #ca-unwatch.icon a {
1114 - background-image: url(images/watch-icons.png);
 1114+ background-image: url(images/watch-icons.png?1);
11151115 background-position: -43px 60%;
11161116 }
11171117 #ca-watch.icon a {
1118 - background-image: url(images/watch-icons.png);
 1118+ background-image: url(images/watch-icons.png?1);
11191119 background-position: 5px 60%;
11201120 }
11211121 #ca-unwatch.icon a:hover {
1122 - background-image: url(images/watch-icons.png);
 1122+ background-image: url(images/watch-icons.png?1);
11231123 background-position: -67px 60%;
11241124 }
11251125 #ca-watch.icon a:hover {
1126 - background-image: url(images/watch-icons.png);
 1126+ background-image: url(images/watch-icons.png?1);
11271127 background-position: -19px 60%;
11281128 }
11291129 #ca-unwatch.icon a.loading,
11301130 #ca-watch.icon a.loading {
1131 - background-image: url(images/watch-icon-loading.gif);
 1131+ background-image: url(images/watch-icon-loading.gif?1);
11321132 background-position: center 60%;
11331133 }
11341134 #ca-unwatch.icon a span,
@@ -1135,7 +1135,7 @@
11361136 display: none;
11371137 }
11381138 div.vectorTabs ul {
1139 - background-image:url(images/tab-break.png);
 1139+ background-image:url(images/tab-break.png?1);
11401140 background-position:left bottom;
11411141 background-repeat:no-repeat;
11421142 }
\ No newline at end of file
Property changes on: branches/wmf/1.16wmf4/skins/vector
___________________________________________________________________
Name: svn:mergeinfo
11431143 - /branches/wmf-deployment/skins/vector:60970
/trunk/phase3/skins/vector:63545-63546,63549,63643,63764,63897-63901,64456,65015,65383,65387,65391,65555,65590-65591
11441144 + /branches/wmf-deployment/skins/vector:60970
/trunk/phase3/skins/vector:63545-63546,63549,63643,63764,63897-63901,64456,65015,65383,65387,65391,65555,65590-65591,65965
Index: branches/wmf/1.16wmf4/includes/DefaultSettings.php
@@ -1687,7 +1687,7 @@
16881688 * to ensure that client-side caches do not keep obsolete copies of global
16891689 * styles.
16901690 */
1691 -$wgStyleVersion = '274';
 1691+$wgStyleVersion = '276';
16921692
16931693
16941694 # Server-side caching:
Property changes on: branches/wmf/1.16wmf4/includes/DefaultSettings.php
___________________________________________________________________
Name: svn:mergeinfo
16951695 - /branches/REL1_15/phase3/includes/DefaultSettings.php:51646
/branches/sqlite/includes/DefaultSettings.php:58211-58321
/branches/wmf-deployment/includes/DefaultSettings.php:53381,60970
/trunk/phase3/includes/DefaultSettings.php:63549,63764,63897-63901,64692,64851,64856,64876,64892,64918,64948,65387,65391,65555,65590
16961696 + /branches/REL1_15/phase3/includes/DefaultSettings.php:51646
/branches/sqlite/includes/DefaultSettings.php:58211-58321
/branches/wmf-deployment/includes/DefaultSettings.php:53381,60970
/trunk/phase3/includes/DefaultSettings.php:63549,63764,63897-63901,64692,64851,64856,64876,64892,64918,64948,65387,65391,65555,65590,65965

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65965Added versions to the URLs of all images in the Vector skin.tparscal21:42, 5 May 2010

Status & tagging log