r65962 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r65961‎ | r65962 | r65963 >
Date:20:15, 5 May 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Switch MediaWiki to jQuery 1.4.2 (was 1.3.2) and enable jQuery on every page by default.
* Make jQuery version configurable with $wgJQueryVersion ; current options are 1.3.2 and 1.4.2
* Make minifying of jQuery configurable with $wgJQueryMinified (enabled by default)
* Allow inclusion of jQuery on every page served by MW with $wgJQueryOnEveryPage (enabled by default)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/skins/common/jquery-1.3.2.js (added) (history)
  • /trunk/phase3/skins/common/jquery-1.3.2.min.js (added) (history)
  • /trunk/phase3/skins/common/jquery-1.4.2.js (added) (history)
  • /trunk/phase3/skins/common/jquery-1.4.2.min.js (added) (history)
  • /trunk/phase3/skins/common/jquery.js (deleted) (history)
  • /trunk/phase3/skins/common/jquery.min.js (deleted) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r66270Followup to r65962: we need to keep jquery.min.js around because cached pages...catrope13:46, 12 May 2010
r79641Removing Makefile from /skins/common (only used for minifiying jquery, which ...krinkle12:21, 5 January 2011

Comments

#Comment by Catrope (talk | contribs)   12:40, 6 May 2010

Marking this as scaptrap because upgrading jQuery from 1.3.2 to 1.4.2 on WMF wikis may break user scripts and gadgets and the like. The UsabilityInitiative extension is compatible with both.

Also, $wgJQueryOnEveryPage = true; is probably not a very good thing to enable on WMF wikis as long as bug 19586 (jQuery-mwsuggest interaction prevents Opera 8 users from logging in) hasn't been resolved.

Status & tagging log