r65468 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65467‎ | r65468 | r65469 >
Date:17:16, 23 April 2010
Author:yaron
Status:deferred
Tags:
Comment:
Re-added </li> tags at the end of list elements - they may not be necessary in MediaWiki, but they're necessary for correct HTML
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php
@@ -61,7 +61,7 @@
6262 $rowstart = '<li>';
6363 $rowend = '</li>';
6464 $plainlist = false;
65 - } else { // "list" and "tempalte" format
 65+ } else { // "list" and "template" format
6666 $header = '';
6767 $footer = '';
6868 $rowstart = '';
@@ -150,8 +150,7 @@
151151 }
152152 if ( $found_values ) $result .= ')';
153153 }
154 - // </li> tag is not necessary in MediaWiki
155 - // $result .= $rowend;
 154+ $result .= $rowend . "\n";
156155 }
157156
158157 // Make label for finding further results
@@ -170,8 +169,7 @@
171170 $link->setParameter( $this->m_params['link'], 'link' );
172171 }
173172 }
174 - // </li> tag is not necessary in MediaWiki
175 - $result .= $rowstart . $link->getText( SMW_OUTPUT_WIKI, $this->mLinker );// . $rowend;
 173+ $result .= $rowstart . $link->getText( SMW_OUTPUT_WIKI, $this->mLinker ) . $rowend . "\n";
176174 }
177175 if ( $this->mColumns > 1 )
178176 $result .= '</div>' . "\n";

Follow-up revisions

RevisionCommit summaryAuthorDate
r66049Fix for too many newlines added in r65468yaron20:54, 7 May 2010

Status & tagging log