r66049 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66048‎ | r66049 | r66050 >
Date:20:54, 7 May 2010
Author:yaron
Status:deferred
Tags:
Comment:
Fix for too many newlines added in r65468
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php
@@ -59,7 +59,7 @@
6060 $header = '<' . $this->mFormat . '>';
6161 $footer = '</' . $this->mFormat . '>';
6262 $rowstart = '<li>';
63 - $rowend = '</li>';
 63+ $rowend = "</li>\n";
6464 $plainlist = false;
6565 } else { // "list" and "template" format
6666 $header = '';
@@ -150,7 +150,7 @@
151151 }
152152 if ( $found_values ) $result .= ')';
153153 }
154 - $result .= $rowend . "\n";
 154+ $result .= $rowend;
155155 }
156156
157157 // Make label for finding further results
@@ -169,7 +169,7 @@
170170 $link->setParameter( $this->m_params['link'], 'link' );
171171 }
172172 }
173 - $result .= $rowstart . $link->getText( SMW_OUTPUT_WIKI, $this->mLinker ) . $rowend . "\n";
 173+ $result .= $rowstart . $link->getText( SMW_OUTPUT_WIKI, $this->mLinker ) . $rowend;
174174 }
175175 if ( $this->mColumns > 1 )
176176 $result .= '</div>' . "\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65468Re-added </li> tags at the end of list elements - they may not be necessary i...yaron17:16, 23 April 2010

Status & tagging log