r65402 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65401‎ | r65402 | r65403 >
Date:15:37, 21 April 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r64932, bug 23148: ImageMagick comment escaping bug
Modified paths:
  • /branches/wmf/1.16wmf4/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/includes/media/Bitmap.php
@@ -157,7 +157,7 @@
158158 // or ImageMagick may decide your ratio is wrong and slice off
159159 // a pixel.
160160 " -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) .
161 - " -set comment " . wfEscapeShellArg( "{$descriptionUrl}" ) .
 161+ " -set comment " . wfEscapeShellArg( str_replace( '%', '%%', $descriptionUrl ) ) .
162162 " -depth 8 $sharpen " .
163163 wfEscapeShellArg($dstPath) . " 2>&1";
164164 wfDebug( __METHOD__.": running ImageMagick: $cmd\n");
Property changes on: branches/wmf/1.16wmf4/includes/media/Bitmap.php
___________________________________________________________________
Name: svn:mergeinfo
165165 - /branches/REL1_15/phase3/includes/media/Bitmap.php:51646
/branches/sqlite/includes/media/Bitmap.php:58211-58321
/branches/wmf-deployment/includes/media/Bitmap.php:53381,60970
/trunk/phase3/includes/media/Bitmap.php:63549,63764,63897-63901,64691-64692
166166 + /branches/REL1_15/phase3/includes/media/Bitmap.php:51646
/branches/sqlite/includes/media/Bitmap.php:58211-58321
/branches/wmf-deployment/includes/media/Bitmap.php:53381,60970
/trunk/phase3/includes/media/Bitmap.php:63549,63764,63897-63901,64691-64692,64932,65401

Follow-up revisions

RevisionCommit summaryAuthorDate
r65467More rigorous fix for ImageMagick parameter interpretation (bug 23148 etc.) b...tstarling16:24, 23 April 2010
r65681MFT r65467 (and r64935, r64936, r64947 to sync the base): updated fix for bug...tstarling05:33, 30 April 2010
r65682MFT r65467 (and r64935, r64936, r64947 to sync the base): updated fix for bug...tstarling05:37, 30 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64932(bug 23148) Escape % in ImageMagick comments. Patch by Derk-Jan Hartmancatrope12:38, 11 April 2010
r65401MFT r64932, bug 23148: ImageMagick comment escaping. Noted security implicati...tstarling15:35, 21 April 2010

Status & tagging log