r65373 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65372‎ | r65373 | r65374 >
Date:10:53, 21 April 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r64846, bug 23127: Re-added missing $1 parameter to the uploadtext message
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/includes/specials (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/specials/SpecialUpload.php
@@ -231,7 +231,9 @@
232232 }
233233
234234 # Add text to form
235 - $form->addPreText( '<div id="uploadtext">' . wfMsgExt( 'uploadtext', 'parse' ) . '</div>');
 235+ $form->addPreText( '<div id="uploadtext">' .
 236+ wfMsgExt( 'uploadtext', 'parse', array( $this->mDesiredDestName ) ) .
 237+ '</div>' );
236238 # Add upload error message
237239 $form->addPreText( $message );
238240
Property changes on: branches/REL1_16/phase3/includes/specials
___________________________________________________________________
Name: svn:mergeinfo
239241 - /branches/REL1_15/phase3/includes/specials:51646
/branches/sqlite/includes/specials:58211-58321
/branches/wmf-deployment/includes/specials:53381,56967
/trunk/phase3/includes/specials:63045,63047,63490,63549,63764,63897-63901,64180,64837,64860,64862
240242 + /branches/REL1_15/phase3/includes/specials:51646
/branches/sqlite/includes/specials:58211-58321
/branches/wmf-deployment/includes/specials:53381,56967
/trunk/phase3/includes/specials:63045,63047,63490,63549,63764,63897-63901,64180,64837,64846,64860,64862
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -47,6 +47,7 @@
4848 * Fixed sorting in [[Special:Allmessages]]
4949 * (bug 23113) Fixed title in the show/hide links on diff pages
5050 * (bug 23117) Fixed API rollback, was returning "badtoken" for valid requests
 51+* (bug 23127) Re-added missing $1 parameter to the uploadtext message
5152
5253 === Changes since 1.16 beta 1 ===
5354

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64846(bug 23127) Fix for r57868, pass destination file name as $1 to uploadtext me...tstarling03:25, 10 April 2010

Status & tagging log