r65372 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65371‎ | r65372 | r65373 >
Date:10:53, 21 April 2010
Author:churchofemacs
Status:ok
Tags:
Comment:
fixing r65339 which broke Upload when file dest was undefined
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -241,7 +241,7 @@
242242 # Note that this is independent from the message 'filewasdeleted' that requires JS
243243 $desiredTitleObj = Title::newFromText( $this->mDesiredDestName, NS_FILE );
244244 $delNotice = ''; // empty by default
245 - if ( !$desiredTitleObj->exists() ) {
 245+ if ( $desiredTitleObj instanceof Title && !$desiredTitleObj->exists() ) {
246246 LogEventsList::showLogExtract( &$delNotice, array( 'delete', 'move' ),
247247 $desiredTitleObj->getPrefixedText(),
248248 '', array( 'lim' => 10,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65339When visiting a 'red link' of a deleted file, a deletion and move log excerpt...churchofemacs20:30, 20 April 2010

Status & tagging log