r64846 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64845‎ | r64846 | r64847 >
Date:03:25, 10 April 2010
Author:tstarling
Status:ok
Tags:
Comment:
(bug 23127) Fix for r57868, pass destination file name as $1 to uploadtext message
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -238,7 +238,9 @@
239239 }
240240
241241 # Add text to form
242 - $form->addPreText( '<div id="uploadtext">' . wfMsgExt( 'uploadtext', 'parse' ) . '</div>');
 242+ $form->addPreText( '<div id="uploadtext">' .
 243+ wfMsgExt( 'uploadtext', 'parse', array( $this->mDesiredDestName ) ) .
 244+ '</div>' );
243245 # Add upload error message
244246 $form->addPreText( $message );
245247

Follow-up revisions

RevisionCommit summaryAuthorDate
r64847MFT r64846: fix $1 in uploadtexttstarling03:26, 10 April 2010
r65373MFT r64846, bug 23127: Re-added missing $1 parameter to the uploadtext messagetstarling10:53, 21 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57868Rewrote Special:Upload to allow easier extension. Mostly backwards compatible...btongminh19:41, 18 October 2009

Status & tagging log