r65371 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65370‎ | r65371 | r65372 >
Date:10:41, 21 April 2010
Author:tstarling
Status:deferred
Tags:
Comment:
(bug 23117) Fix totally broken action=rollback, by doing a temporary hack along the lines of r64868. Tested.
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/includes/api/ApiRollback.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/api/ApiRollback.php
@@ -121,10 +121,6 @@
122122 array( 'invaliduser', 'user' ),
123123 ) );
124124 }
125 -
126 - public function getTokenSalt() {
127 - return '';
128 - }
129125
130126 protected function getExamples() {
131127 return array (
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -46,6 +46,7 @@
4747 invalid usernames.
4848 * Fixed sorting in [[Special:Allmessages]]
4949 * (bug 23113) Fixed title in the show/hide links on diff pages
 50+* (bug 23117) Fixed API rollback, was returning "badtoken" for valid requests
5051
5152 === Changes since 1.16 beta 1 ===
5253

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64826Refactor code in ApiRollback to fix bug 23117...reedy20:05, 9 April 2010
r648681.16wmf4: Commit live hack for bug 23117catrope12:08, 10 April 2010

Status & tagging log