r64868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64867‎ | r64868 | r64869 >
Date:12:08, 10 April 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.16wmf4: Commit live hack for bug 23117
Modified paths:
  • /branches/wmf/1.16wmf4/includes/api/ApiRollback.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/includes/api/ApiRollback.php
@@ -121,11 +121,12 @@
122122 array( 'invaliduser', 'user' ),
123123 ) );
124124 }
125 -
126 - public function getTokenSalt() {
127 - return '';
128 - }
129125
 126+// LIVE HACK: Disable, causes breakage
 127+// public function getTokenSalt() {
 128+// return '';
 129+// }
 130+
130131 protected function getExamples() {
131132 return array (
132133 'api.php?action=rollback&title=Main%20Page&user=Catrope&token=123ABC',

Follow-up revisions

RevisionCommit summaryAuthorDate
r65371(bug 23117) Fix totally broken action=rollback, by doing a temporary hack alo...tstarling10:41, 21 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64826Refactor code in ApiRollback to fix bug 23117...reedy20:05, 9 April 2010

Comments

#Comment by Tim Starling (talk | contribs)   16:31, 20 April 2010

Equivalent in trunk is r64826

Status & tagging log