r65045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65044‎ | r65045 | r65046 >
Date:08:56, 15 April 2010
Author:vasilievvv
Status:ok (Comments)
Tags:
Comment:
This actually can happen when home account is unmerged or renamed.
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuth.i18n.php (modified) (history)
  • /trunk/extensions/CentralAuth/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialCentralAuth.php
@@ -601,8 +601,8 @@
602602 }
603603 }
604604
605 - // Should not happen.
606 - throw new MWException( 'Failed to determine home wiki' );
 605+ // Home account can be renamed or unmerged
 606+ return wfMsgHtml( 'centralauth-admin-nohome' );
607607 }
608608
609609 function evaluateTotalEditcount() {
Index: trunk/extensions/CentralAuth/CentralAuth.i18n.php
@@ -146,6 +146,7 @@
147147 'centralauth-admin-info-editcount' => 'Total editcount:',
148148 'centralauth-admin-info-locked' => 'Locked:',
149149 'centralauth-admin-info-hidden' => 'Hidden level:',
 150+ 'centralauth-admin-nohome' => 'unable to determine',
150151 'centralauth-admin-yes' => 'yes',
151152 'centralauth-admin-no' => 'no',
152153 'centralauth-admin-hidden-list' => 'from public lists',

Follow-up revisions

RevisionCommit summaryAuthorDate
r65048MFT r65045: fix exception exposed to userststarling09:24, 15 April 2010

Comments

#Comment by Tim Starling (talk | contribs)   09:03, 15 April 2010

needs deployment

#Comment by Nikerabbit (talk | contribs)   09:09, 15 April 2010

"unable to determine" huh? Please provide documentation for translators.

#Comment by VasilievVV (talk | contribs)   09:23, 15 April 2010

Added in r65047.

#Comment by Nikerabbit (talk | contribs)   09:29, 15 April 2010

Thanks! I tweaked it a bit.

Status & tagging log