r65048 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65047‎ | r65048 | r65049 >
Date:09:24, 15 April 2010
Author:tstarling
Status:ok
Tags:
Comment:
MFT r65045: fix exception exposed to users
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/CentralAuth (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralAuth/CentralAuth.i18n.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralAuth/CentralAuthUser.php (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/CentralAuth/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Property changes on: branches/wmf/1.16wmf4/extensions/CentralAuth/CentralAuthUser.php
___________________________________________________________________
Name: svn:mergeinfo
11 - /branches/wmf-deployment/extensions/CentralAuth/CentralAuthUser.php:60970
/trunk/extensions/CentralAuth/CentralAuthUser.php:62827,64771,64982
22 + /branches/wmf-deployment/extensions/CentralAuth/CentralAuthUser.php:60970
/trunk/extensions/CentralAuth/CentralAuthUser.php:62827,64771,64982,65045
Index: branches/wmf/1.16wmf4/extensions/CentralAuth/SpecialCentralAuth.php
@@ -586,8 +586,8 @@
587587 }
588588 }
589589
590 - // Should not happen.
591 - throw new MWException( 'Failed to determine home wiki' );
 590+ // Home account can be renamed or unmerged
 591+ return wfMsgHtml( 'centralauth-admin-nohome' );
592592 }
593593
594594 function evaluateTotalEditcount() {
Index: branches/wmf/1.16wmf4/extensions/CentralAuth/CentralAuth.i18n.php
@@ -146,6 +146,7 @@
147147 'centralauth-admin-info-editcount' => 'Total editcount:',
148148 'centralauth-admin-info-locked' => 'Locked:',
149149 'centralauth-admin-info-hidden' => 'Hidden level:',
 150+ 'centralauth-admin-nohome' => 'unable to determine',
150151 'centralauth-admin-yes' => 'yes',
151152 'centralauth-admin-no' => 'no',
152153 'centralauth-admin-hidden-list' => 'from public lists',
Property changes on: branches/wmf/1.16wmf4/extensions/CentralAuth
___________________________________________________________________
Name: svn:mergeinfo
153154 - /branches/wmf-deployment/extensions/CentralAuth:60970
/trunk/extensions/CentralAuth:62827,64771
154155 + /branches/wmf-deployment/extensions/CentralAuth:60970
/trunk/extensions/CentralAuth:62827,64771,65045

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65045This actually can happen when home account is unmerged or renamed.vasilievvv08:56, 15 April 2010

Status & tagging log