r64815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64814‎ | r64815 | r64816 >
Date:18:08, 9 April 2010
Author:platonides
Status:deferred
Tags:
Comment:
Follow up r64813 and r64814 by also applying r64814 to the branches.
Modified paths:
  • /branches/REL1_16/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/wmf/1.16wmf4/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -348,8 +348,8 @@
349349 * The page doesn't get language converted if
350350 * a) It's disabled
351351 * b) Titles aren't converted
352 - * c) Content isn't converted and this is not a talk page
353 - * d) It's a conversion table
 352+ * c) Content isn't converted and this is not a talk page
 353+ * d) It's a conversion table
354354 */
355355 if ( !( $wgDisableLangConversion
356356 || isset( $this->mDoubleUnderscores['notitleconvert'] )
Index: branches/wmf/1.16wmf4/includes/parser/Parser.php
@@ -346,12 +346,22 @@
347347
348348 $this->replaceLinkHolders( $text );
349349
350 - // The position of the convert() call should not be changed. it
351 - // assumes that the links are all replaced and the only thing left
352 - // is the <nowiki> mark.
 350+ /**
 351+ * The page doesn't get language converted if
 352+ * a) It's disabled
 353+ * b) Titles aren't converted
 354+ * c) Content isn't converted and this is not a talk page
 355+ * d) It's a conversion table
 356+ */
353357 if ( !( $wgDisableLangConversion
354 - || isset( $this->mDoubleUnderscores['nocontentconvert'] )
 358+ || isset( $this->mDoubleUnderscores['notitleconvert'] )
 359+ || ( isset( $this->mDoubleUnderscores['nocontentconvert'] ) && !$this->mTitle->isTalkPage() )
355360 || $this->mTitle->isConversionTable() ) ) {
 361+
 362+ # The position of the convert() call should not be changed. it
 363+ # assumes that the links are all replaced and the only thing left
 364+ # is the <nowiki> mark.
 365+
356366 $text = $wgContLang->convert( $text );
357367 }
358368
Index: branches/REL1_16/phase3/includes/parser/Parser.php
@@ -346,12 +346,22 @@
347347
348348 $this->replaceLinkHolders( $text );
349349
350 - // The position of the convert() call should not be changed. it
351 - // assumes that the links are all replaced and the only thing left
352 - // is the <nowiki> mark.
 350+ /**
 351+ * The page doesn't get language converted if
 352+ * a) It's disabled
 353+ * b) Titles aren't converted
 354+ * c) Content isn't converted and this is not a talk page
 355+ * d) It's a conversion table
 356+ */
353357 if ( !( $wgDisableLangConversion
354 - || isset( $this->mDoubleUnderscores['nocontentconvert'] )
 358+ || isset( $this->mDoubleUnderscores['notitleconvert'] )
 359+ || ( isset( $this->mDoubleUnderscores['nocontentconvert'] ) && !$this->mTitle->isTalkPage() )
355360 || $this->mTitle->isConversionTable() ) ) {
 361+
 362+ # The position of the convert() call should not be changed. it
 363+ # assumes that the links are all replaced and the only thing left
 364+ # is the <nowiki> mark.
 365+
356366 $text = $wgContLang->convert( $text );
357367 }
358368

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64813Follow up r64811. Language Converter should apply on talk page. Fix this bug ...philip17:51, 9 April 2010
r64814Follow-up r64811 on fixing bug 23115....platonides17:56, 9 April 2010

Status & tagging log