r64814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64813‎ | r64814 | r64815 >
Date:17:56, 9 April 2010
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
Follow-up r64811 on fixing bug 23115.
This restores convert rules to the same ones as before r61101.
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -344,12 +344,22 @@
345345
346346 $this->replaceLinkHolders( $text );
347347
348 - # The position of the convert() call should not be changed. it
349 - # assumes that the links are all replaced and the only thing left
350 - # is the <nowiki> mark.
 348+ /**
 349+ * The page doesn't get language converted if
 350+ * a) It's disabled
 351+ * b) Titles aren't converted
 352+ * c) Content isn't converted and this is not a talk page
 353+ * d) It's a conversion table
 354+ */
351355 if ( !( $wgDisableLangConversion
352 - || isset( $this->mDoubleUnderscores['nocontentconvert'] )
 356+ || isset( $this->mDoubleUnderscores['notitleconvert'] )
 357+ || ( isset( $this->mDoubleUnderscores['nocontentconvert'] ) && !$this->mTitle->isTalkPage() )
353358 || $this->mTitle->isConversionTable() ) ) {
 359+
 360+ # The position of the convert() call should not be changed. it
 361+ # assumes that the links are all replaced and the only thing left
 362+ # is the <nowiki> mark.
 363+
354364 $text = $wgContLang->convert( $text );
355365 }
356366

Follow-up revisions

RevisionCommit summaryAuthorDate
r64815Follow up r64813 and r64814 by also applying r64814 to the branches.platonides18:08, 9 April 2010
r64851Fix bug 23115 again. Follow up r64821, r64823 and r64827. Rewrite the convert...philip05:46, 10 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61101follow up r60832 and follow up r60763...mah19:14, 15 January 2010
r64811Bug 23115: Language Converter should apply on talk page.philip17:42, 9 April 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   17:57, 10 December 2010

Effectively reverted by r64819

Status & tagging log