r64816 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64815‎ | r64816 | r64817 >
Date:18:21, 9 April 2010
Author:ialex
Status:ok
Tags:
Comment:
Fixes for r64708:
* removed the other disallowUserJs() call, for consistency with Special:Preferences
* removed RELEASE-NOTES entry

Also changed "SpecialPage::getTitleFor( 'Restpass' )" to $this->getTitle().
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialResetpass.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialResetpass.php
@@ -90,9 +90,7 @@
9191 function showForm() {
9292 global $wgOut, $wgUser, $wgRequest;
9393
94 - $wgOut->disallowUserJs();
95 -
96 - $self = SpecialPage::getTitleFor( 'Resetpass' );
 94+ $self = $this->getTitle();
9795 if ( !$this->mUserName ) {
9896 $this->mUserName = $wgUser->getName();
9997 }
Index: trunk/phase3/RELEASE-NOTES
@@ -96,7 +96,6 @@
9797 exceeding $wgMaxImageArea can still be embedded at original size
9898 * (bug 23078) "All public logs" option on Special:Log is now always the first
9999 item
100 -* Special:ChangePassword no longer loads user javascript
101100 * (bug 16817) Group names in user rights log are now singular and in lowercase
102101
103102 === API changes in 1.17 ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64708* Special:ChangePassword no longer loads user javascriptialex15:47, 7 April 2010

Status & tagging log