r64404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64403‎ | r64404 | r64405 >
Date:19:32, 30 March 2010
Author:nimishg
Status:ok (Comments)
Tags:
Comment:
Fixed minor issues of Usability test: font style for help and default table dialog settings matching the example
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.toolbar.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -25,15 +25,15 @@
2626 array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 28 ),
2727 array( 'src' => 'css/wikiEditor.preview.css', 'version' => 1 ),
2828 array( 'src' => 'css/wikiEditor.toc.css', 'version' => 30 ),
29 - array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 13 ),
 29+ array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 14 ),
3030 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3131 ),
3232 'combined' => array(
33 - array( 'src' => 'css/combined.css', 'version' => 82 ),
 33+ array( 'src' => 'css/combined.css', 'version' => 83 ),
3434 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3535 ),
3636 'minified' => array(
37 - array( 'src' => 'css/combined.min.css', 'version' => 82 ),
 37+ array( 'src' => 'css/combined.min.css', 'version' => 83 ),
3838 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3939 ),
4040 )
Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.toolbar.css
@@ -338,13 +338,17 @@
339339 body.rtl .wikiEditor-ui-toolbar .page-table td {
340340 text-align: right;
341341 }
 342+.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
342343 .wikiEditor-ui-toolbar .section-help .page-table td.syntax {
343344 font-family: monospace;
344345 }
345346 .wikiEditor-ui-toolbar .section-help .page-table td.syntax,
 347+.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
 348+.wikiEditor-ui-toolbar .section-help .page-table td.cell-result,
346349 .wikiEditor-ui-toolbar .section-help .page-table td.result {
347350 width: 40%;
348351 }
 352+.wikiEditor-ui-toolbar .section-help .page-table td.description,
349353 .wikiEditor-ui-toolbar .section-help .page-table td.description {
350354 width: 20%;
351355 }
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -1115,13 +1115,17 @@
11161116 body.rtl .wikiEditor-ui-toolbar .page-table td {
11171117 text-align: right;
11181118 }
 1119+.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
11191120 .wikiEditor-ui-toolbar .section-help .page-table td.syntax {
11201121 font-family: monospace;
11211122 }
11221123 .wikiEditor-ui-toolbar .section-help .page-table td.syntax,
 1124+.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
 1125+.wikiEditor-ui-toolbar .section-help .page-table td.cell-result,
11231126 .wikiEditor-ui-toolbar .section-help .page-table td.result {
11241127 width: 40%;
11251128 }
 1129+.wikiEditor-ui-toolbar .section-help .page-table td.description,
11261130 .wikiEditor-ui-toolbar .section-help .page-table td.description {
11271131 width: 20%;
11281132 }
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -1050,13 +1050,17 @@
10511051 body.rtl .wikiEditor-ui-toolbar .page-table td{
10521052 text-align:right;
10531053 }
 1054+.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
10541055 .wikiEditor-ui-toolbar .section-help .page-table td.syntax{
10551056 font-family:monospace;
10561057 }
10571058 .wikiEditor-ui-toolbar .section-help .page-table td.syntax,
 1059+.wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
 1060+.wikiEditor-ui-toolbar .section-help .page-table td.cell-result,
10581061 .wikiEditor-ui-toolbar .section-help .page-table td.result{
10591062 width:40%;
10601063 }
 1064+.wikiEditor-ui-toolbar .section-help .page-table td.description,
10611065 .wikiEditor-ui-toolbar .section-help .page-table td.description{
10621066 width:20%;
10631067 }
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js
@@ -1777,7 +1777,7 @@
17781778 );
17791779
17801780 // Restore form state
1781 - $j( '#wikieditor-toolbar-table-dimensions-rows' ).val( 4 );
 1781+ $j( '#wikieditor-toolbar-table-dimensions-rows' ).val( 3 );
17821782 $j( '#wikieditor-toolbar-table-dimensions-columns' ).val( 3 );
17831783 // Simulate clicks instead of setting values, so the according
17841784 // actions are performed
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.min.js
@@ -151,7 +151,7 @@
152152 table=table.substr(0,table.length-1)+"\n";}
153153 var classes=[];if($j('#wikieditor-toolbar-table-wikitable').is(':checked'))
154154 classes.push('wikitable');if($j('#wikieditor-toolbar-table-sortable').is(':checked'))
155 -classes.push('sortable');var classStr=classes.length>0?' class="'+classes.join(' ')+'"':'';$j(this).dialog('close');$j.wikiEditor.modules.toolbar.fn.doAction($j(this).data('context'),{type:'replace',options:{pre:'{|'+classStr+"\n",peri:table,post:'|}',ownline:true}},$j(this));$j('#wikieditor-toolbar-table-dimensions-rows').val(4);$j('#wikieditor-toolbar-table-dimensions-columns').val(3);if(!$j('#wikieditor-toolbar-table-dimensions-header').is(':checked'))
 155+classes.push('sortable');var classStr=classes.length>0?' class="'+classes.join(' ')+'"':'';$j(this).dialog('close');$j.wikiEditor.modules.toolbar.fn.doAction($j(this).data('context'),{type:'replace',options:{pre:'{|'+classStr+"\n",peri:table,post:'|}',ownline:true}},$j(this));$j('#wikieditor-toolbar-table-dimensions-rows').val(3);$j('#wikieditor-toolbar-table-dimensions-columns').val(3);if(!$j('#wikieditor-toolbar-table-dimensions-header').is(':checked'))
156156 $j('#wikieditor-toolbar-table-dimensions-header').click();if(!$j('#wikieditor-toolbar-table-wikitable').is(':checked'))
157157 $j('#wikieditor-toolbar-table-wikitable').click();if($j('#wikieditor-toolbar-table-sortable').is(':checked'))
158158 $j('#wikieditor-toolbar-table-sortable').click();},'wikieditor-toolbar-tool-table-cancel':function(){$j(this).dialog('close');}},open:function(){$j('#wikieditor-toolbar-table-dimensions-rows').focus();if(!($j(this).data('dialogkeypressset'))){$j(this).data('dialogkeypressset',true);$j(this).closest('.ui-dialog').keypress(function(e){if((e.keyCode||e.which)==13){var button=$j(this).data('dialogaction')||$j(this).find('button:first');button.click();e.preventDefault();}});$j(this).closest('.ui-dialog').find('button').focus(function(){$j(this).closest('.ui-dialog').data('dialogaction',this);});}}}},'search-and-replace':{'browsers':{'ltr':{'msie':[['>=',7]],'firefox':[['>=',2]],'opera':false,'safari':[['>=',3]],'chrome':[['>=',3]]},'rtl':{'msie':[['>=',8]],'firefox':[['>=',2]],'opera':false,'safari':[['>=',3]],'chrome':[['>=',3]]}},filters:['#wpTextbox1.toolbar-dialogs'],titleMsg:'wikieditor-toolbar-tool-replace-title',id:'wikieditor-toolbar-replace-dialog',html:'\
Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js
@@ -1728,7 +1728,7 @@
17291729 );
17301730
17311731 // Restore form state
1732 - $j( '#wikieditor-toolbar-table-dimensions-rows' ).val( 4 );
 1732+ $j( '#wikieditor-toolbar-table-dimensions-rows' ).val( 3 );
17331733 $j( '#wikieditor-toolbar-table-dimensions-columns' ).val( 3 );
17341734 // Simulate clicks instead of setting values, so the according
17351735 // actions are performed

Follow-up revisions

RevisionCommit summaryAuthorDate
r64455merged changes from r64404. r64167, r64354 into deployment for UX testnimishg20:23, 31 March 2010

Comments

#Comment by Catrope (talk | contribs)   20:03, 30 March 2010

Missing bump of Toolbar.js version in WikiEditor.hooks.php

Status & tagging log