r64167 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64166‎ | r64167 | r64168 >
Date:18:35, 25 March 2010
Author:nimishg
Status:ok
Tags:
Comment:
link dialog no longer overwrites user's existing entry
Modified paths:
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -16,14 +16,14 @@
1717 array( 'src' => 'Modules/Preview/Preview.js', 'version' => 6 ),
1818 array( 'src' => 'Modules/Publish/Publish.js', 'version' => 6 ),
1919 array( 'src' => 'Modules/Toc/Toc.js', 'version' => 7 ),
20 - array( 'src' => 'Modules/Toolbar/Toolbar.js', 'version' => 66 ),
 20+ array( 'src' => 'Modules/Toolbar/Toolbar.js', 'version' => 67 ),
2121 array( 'src' => 'Modules/TemplateEditor/TemplateEditor.js', 'version' => 6 ),
2222 ),
2323 'combined' => array(
24 - array( 'src' => 'WikiEditor.combined.js', 'version' => 70 ),
 24+ array( 'src' => 'WikiEditor.combined.js', 'version' => 71 ),
2525 ),
2626 'minified' => array(
27 - array( 'src' => 'WikiEditor.combined.min.js', 'version' => 70 ),
 27+ array( 'src' => 'WikiEditor.combined.min.js', 'version' => 71 ),
2828 ),
2929 );
3030 static $messages = array(
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js
@@ -1373,6 +1373,11 @@
13741374 );
13751375 $j( '#wikieditor-toolbar-link-int-target' ).suggestions();
13761376
 1377+ //don't overwrite user's text
 1378+ if( selection != '' ){
 1379+ $j( '#wikieditor-toolbar-link-int-text' ).data( 'untouched', false );
 1380+ }
 1381+
13771382 $j( '#wikieditor-toolbar-link-int-text, #wikiedit-toolbar-link-int-target' )
13781383 .each( function() {
13791384 if ( $j(this).val() == '' )
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.min.js
@@ -72,7 +72,8 @@
7373 $j('#wikieditor-toolbar-link-int-text').val(text).change();if(typeof target!='undefined')
7474 $j('#wikieditor-toolbar-link-int-target').val(target).change();if(typeof type!='undefined')
7575 $j('#wikieditor-toolbar-link-'+type).attr('checked','checked');}
76 -$j('#wikieditor-toolbar-link-int-text').data('untouched',$j('#wikieditor-toolbar-link-int-text').val()==$j('#wikieditor-toolbar-link-int-target').val()||$j('#wikieditor-toolbar-link-int-text').hasClass('wikieditor-toolbar-dialog-hint'));$j('#wikieditor-toolbar-link-int-target').suggestions();$j('#wikieditor-toolbar-link-int-text, #wikiedit-toolbar-link-int-target').each(function(){if($j(this).val()=='')
 76+$j('#wikieditor-toolbar-link-int-text').data('untouched',$j('#wikieditor-toolbar-link-int-text').val()==$j('#wikieditor-toolbar-link-int-target').val()||$j('#wikieditor-toolbar-link-int-text').hasClass('wikieditor-toolbar-dialog-hint'));$j('#wikieditor-toolbar-link-int-target').suggestions();if(selection!=''){$j('#wikieditor-toolbar-link-int-text').data('untouched',false);}
 77+$j('#wikieditor-toolbar-link-int-text, #wikiedit-toolbar-link-int-target').each(function(){if($j(this).val()=='')
7778 $j(this).parent().find('label').show();});if(!($j(this).data('dialogkeypressset'))){$j(this).data('dialogkeypressset',true);$j(this).closest('.ui-dialog').keypress(function(e){if((e.keyCode||e.which)==13){var button=$j(this).data('dialogaction')||$j(this).find('button:first');button.click();e.preventDefault();}});$j(this).closest('.ui-dialog').find('button').focus(function(){$j(this).closest('.ui-dialog').data('dialogaction',this);});}}}},'insert-table':{filters:['#wpTextbox1.toolbar-dialogs'],titleMsg:'wikieditor-toolbar-tool-table-title',id:'wikieditor-toolbar-table-dialog',html:'\
7879 <div class="wikieditor-toolbar-dialog-wrapper">\
7980 <fieldset><div class="wikieditor-toolbar-table-form">\
Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js
@@ -1324,6 +1324,11 @@
13251325 );
13261326 $j( '#wikieditor-toolbar-link-int-target' ).suggestions();
13271327
 1328+ //don't overwrite user's text
 1329+ if( selection != '' ){
 1330+ $j( '#wikieditor-toolbar-link-int-text' ).data( 'untouched', false );
 1331+ }
 1332+
13281333 $j( '#wikieditor-toolbar-link-int-text, #wikiedit-toolbar-link-int-target' )
13291334 .each( function() {
13301335 if ( $j(this).val() == '' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r64455merged changes from r64404. r64167, r64354 into deployment for UX testnimishg20:23, 31 March 2010

Status & tagging log