r64262 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64261‎ | r64262 | r64263 >
Date:16:12, 27 March 2010
Author:maxsem
Status:resolved
Tags:
Comment:
Follow-up to r64261: HTML is not supported either
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/WebInstallerOutput.php (modified) (history)
  • /branches/new-installer/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -1519,7 +1519,11 @@
15201520
15211521 private function endStage( $success = true ) {
15221522 $msg = $success ? 'config-install-step-done' : 'config-install-step-failed';
1523 - $this->parent->output->addHTML( wfMsgHtml( $msg ) . "</li>\n" );
 1523+ $html = wfMsgHtml( $msg );
 1524+ if ( !$success ) {
 1525+ $html = "<span class=\"error\">$html</html>";
 1526+ }
 1527+ $this->parent->output->addHTML( $html . "</li>\n" );
15241528 }
15251529 }
15261530 class WebInstaller_Complete extends WebInstallerPage {
Index: branches/new-installer/phase3/includes/installer/WebInstallerOutput.php
@@ -88,6 +88,7 @@
8989 <meta name="robots" content="noindex, nofollow" />
9090 <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
9191 <title>MediaWiki <?php echo( htmlspecialchars( $wgVersion ) ); ?> Installation</title>
 92+ <link rel="stylesheet" type="text/css" href="../skins/common/shared.css"/>
9293 <link rel="stylesheet" type="text/css" href="../skins/monobook/main.css"/>
9394 <link rel="stylesheet" type="text/css" href="../skins/common/config.css"/>
9495 <script type="text/javascript"><!--
Index: branches/new-installer/phase3/languages/messages/MessagesEn.php
@@ -4451,7 +4451,7 @@
44524452 They may require additional configuration, but you can enable them now",
44534453
44544454 'config-install-step-done' => 'done',
4455 -'config-install-step-failed' => "<b>FAILED</b>",
 4455+'config-install-step-failed' => 'FAILED',
44564456 'config-install-extensions' => 'Including extensions',
44574457 'config-install-database' => 'Setting up database',
44584458 'config-install-tables' => 'Creating tables',

Follow-up revisions

RevisionCommit summaryAuthorDate
r64266Fixed sysop creation for all DBs, and a mismatched tag from r64262maxsem17:33, 27 March 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64261Wiki-markup is not supported heremaxsem15:56, 27 March 2010

Status & tagging log