r64266 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64265‎ | r64266 | r64267 >
Date:17:33, 27 March 2010
Author:maxsem
Status:ok
Tags:
Comment:
Fixed sysop creation for all DBs, and a mismatched tag from r64262
Modified paths:
  • /branches/new-installer/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -1501,6 +1501,7 @@
15021502 return 'continue';
15031503 }
15041504 $this->startForm();
 1505+ $this->parent->exportVars();
15051506 $this->parent->output->addHTML("<ul>");
15061507 foreach( $this->parent->getInstallSteps() as $step ) {
15071508 $this->startStage( "config-install-$step" );
@@ -1521,7 +1522,7 @@
15221523 $msg = $success ? 'config-install-step-done' : 'config-install-step-failed';
15231524 $html = wfMsgHtml( $msg );
15241525 if ( !$success ) {
1525 - $html = "<span class=\"error\">$html</html>";
 1526+ $html = "<span class=\"error\">$html</span>";
15261527 }
15271528 $this->parent->output->addHTML( $html . "</li>\n" );
15281529 }
Index: branches/new-installer/phase3/includes/installer/Installer.php
@@ -129,7 +129,7 @@
130130 'database',
131131 'tables',
132132 'secretkey',
133 - // 'sysop',
 133+ 'sysop',
134134 'localsettings',
135135 );
136136
@@ -309,6 +309,17 @@
310310 }
311311
312312 /**
 313+ * Exports all wg* variables stored by the installer into global scope
 314+ */
 315+ function exportVars() {
 316+ foreach ( $this->settings as $name => $value ) {
 317+ if ( substr( $name, 0, 2 ) == 'wg' ) {
 318+ $GLOBALS[$name] = $value;
 319+ }
 320+ }
 321+ }
 322+
 323+ /**
313324 * Get a fake password for sending back to the user in HTML.
314325 * This is a security mechanism to avoid compromise of the password in the
315326 * event of session ID compromise.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64262Follow-up to r64261: HTML is not supported eithermaxsem16:12, 27 March 2010

Status & tagging log