r64214 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64213‎ | r64214 | r64215 >
Date:11:21, 26 March 2010
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Get message in wfEmptyMsg using the user's interface language; closer to the previous behaviour and might fix the issue reported in r64178 CR
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2274,7 +2274,7 @@
22752275 */
22762276 function wfEmptyMsg( $key ) {
22772277 global $wgMessageCache;
2278 - return $wgMessageCache->get( $key ) === false;
 2278+ return $wgMessageCache->get( $key, /*useDB*/true, /*content*/false ) === false;
22792279 }
22802280
22812281 /**
Index: trunk/phase3/includes/EditPage.php
@@ -1704,14 +1704,16 @@
17051705 }
17061706 }
17071707
 1708+ /**
 1709+ * Give a chance for site and per-namespace customizations of
 1710+ * terms of service summary link that might exist separately
 1711+ * from the copyright notice.
 1712+ *
 1713+ * This will display between the save button and the edit tools,
 1714+ * so should remain short!
 1715+ */
17081716 protected function showTosSummary() {
17091717 $msg = 'editpage-tos-summary';
1710 - // Give a chance for site and per-namespace customizations of
1711 - // terms of service summary link that might exist separately
1712 - // from the copyright notice.
1713 - //
1714 - // This will display between the save button and the edit tools,
1715 - // so should remain short!
17161718 wfRunHooks( 'EditPageTosSummary', array( $this->mTitle, &$msg ) );
17171719 $text = wfMsg( $msg );
17181720 if( !wfEmptyMsg( $msg, $text ) && $text !== '-' ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64178Make MessageCache::get() return false if the requested message does not exist...happy-melon20:21, 25 March 2010

Comments

#Comment by Werdna (talk | contribs)   03:53, 9 December 2010

Unrelated comment placement change.

Status & tagging log