r64213 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64212‎ | r64213 | r64214 >
Date:07:26, 26 March 2010
Author:tstarling
Status:ok
Tags:
Comment:
* Fixed usage message
* Fixed broken $wgVersion regex replacement
* Fixed UsabilityInitiative source
Modified paths:
  • /trunk/tools/make-wmf-branch/default.conf (modified) (history)
  • /trunk/tools/make-wmf-branch/make-wmf-branch (modified) (history)

Diff [purge]

Index: trunk/tools/make-wmf-branch/make-wmf-branch
@@ -7,7 +7,8 @@
88 }
99
1010 if ( count( $argv ) < 3 ) {
11 - echo "Usage: make-wmf-branch <new-version> <old-version>";
 11+ echo "Usage: make-wmf-branch <new-version> <old-version>\n";
 12+ echo "Example: make-wmf-branch 1.16wmf4 1.16wmf3\n";
1213 exit( 1 );
1314 }
1415
@@ -149,7 +150,7 @@
150151 function fixVersion( $fileName ) {
151152 $s = file_get_contents( $fileName );
152153 $s = preg_replace( '/^( \$wgVersion \s+ = \s+ ) [^;]* ( ; \s* ) $/xm',
153 - "\\1'{$this->newVersion}\2'", $s );
 154+ "\\1'{$this->newVersion}'\\2", $s );
154155 file_put_contents( $fileName, $s );
155156 }
156157 }
Index: trunk/tools/make-wmf-branch/default.conf
@@ -99,7 +99,7 @@
100100 'LiquidThreads' => '^/branches/wmf/1.16wmf3/extensions/LiquidThreads',
101101 'FlaggedRevs_alpha' => '^/branches/wmf/1.16wmf3/extensions/FlaggedRevs_alpha',
102102 'FlaggedRevs' => '^/branches/wmf/1.16wmf3/extensions/FlaggedRevs',
103 - 'UsabilityInitiative' => '^/branches/1.16wmf3/extensions/UsabilityInitiative',
 103+ 'UsabilityInitiative' => '^/branches/wmf/1.16wmf3/extensions/UsabilityInitiative',
104104 );
105105
106106 $preservedItems = array(
@@ -125,7 +125,9 @@
126126 # array( 'rev' => 56394, 'base' => '^/branches/wmf/1.16wmf3' ),
127127
128128 array( 'rev' => 60970, 'base' => '^/branches/wmf/1.16wmf3' ),
129 - array( 'rev' => 62002, 'base' => '^/branches/wmf/1.16wmf3' ),
 129+
 130+ # Not needed for a copy from 1.16wmf3, may be needed for a future copy from trunk
 131+ #array( 'rev' => 62002, 'base' => '^/branches/wmf/1.16wmf3' ),
130132 );
131133
132134 $dryRun = false;

Status & tagging log